Uh oh!
There was an error while loading. Please reload this page.
feat(auth): Allow enabling of anonymous provider via tenant configuration - #802
Conversation
hiranya911
left a comment
There was a problem hiding this comment.
LGTM 👍
Can you add a reference to the API proposal in the description.
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
rsgowman
commented
Dec 23, 2020
Done. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
dgibney
commented
Jan 30, 2021
Looks like this was almost over the line before the holidays hit. Hope this comment may bring it back on someone's radar. Thanks. |
rsgowman
commented
Feb 1, 2021
Thanks for the reminder. I'll get this in front of the appropriate people this week, and we'll see if we can finish it up. (It had stalled due to some internal launch processes, but those were cleared up just before the holidays.) |
5b98a08 to
2668d56Compare
hiranya911
left a comment
There was a problem hiding this comment.
Looks mostly good. Just a couple of questions.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Internal API proposal: http://doc/1ikY2GoQZrwHNJ5mBa---t2o9R-MdjA4np4uW9SJ9dTg#heading=h.x94y9zzc13xn