Skip to content

feat(auth): Allow enabling of anonymous provider via tenant configuration - #802

Merged
rsgowman merged 7 commits into
masterfrom
rsgowman/enable_anon_auth
Feb 8, 2021
Merged

feat(auth): Allow enabling of anonymous provider via tenant configuration#802
rsgowman merged 7 commits into
masterfrom
rsgowman/enable_anon_auth

Conversation

@rsgowman

@rsgowmanrsgowman commented Mar 5, 2020

Copy link
Copy Markdown
Member

@hiranya911hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Can you add a reference to the API proposal in the description.

@hiranya911hiranya911 removed their assignment Mar 6, 2020
@google-cla

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@rsgowman

Copy link
Copy Markdown
MemberAuthor

Can you add a reference to the API proposal in the description.

Done.

@google-cla

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@dgibney

Copy link
Copy Markdown

Looks like this was almost over the line before the holidays hit. Hope this comment may bring it back on someone's radar. Thanks.

@rsgowman

Copy link
Copy Markdown
MemberAuthor

Thanks for the reminder. I'll get this in front of the appropriate people this week, and we'll see if we can finish it up. (It had stalled due to some internal launch processes, but those were cleared up just before the holidays.)

@rsgowman
rsgowmanforce-pushed the rsgowman/enable_anon_auth branch from 5b98a08 to 2668d56CompareFebruary 4, 2021 19:22

@hiranya911hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. Just a couple of questions.

Comment threadsrc/auth/index.ts Outdated
Comment threadtest/unit/auth/tenant-manager.spec.ts
@rsgowmanrsgowman assigned hiranya911 and unassigned rsgowmanFeb 5, 2021

@hiranya911hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiranya911hiranya911 assigned rsgowman and unassigned hiranya911Feb 5, 2021
@rsgowman
rsgowman merged commit a00ce05 into masterFeb 8, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rsgowman@dgibney@hiranya911@bojeil-google