Skip to content

fix(auth): Defines missing DecodedIdToken types. - #852

Merged
bojeil-google merged 4 commits into
masterfrom
missing-types
Apr 17, 2020
Merged

fix(auth): Defines missing DecodedIdToken types.#852
bojeil-google merged 4 commits into
masterfrom
missing-types

Conversation

@bojeil-google

@bojeil-googlebojeil-google commented Apr 17, 2020

Copy link
Copy Markdown
Contributor

Fixes#846

RELEASE NOTE: Exposed email, email_verified, phone_number and picture fields from the DecodedIdToken type.

@hiranya911hiranya911 changed the title Defines missing DecodedIdToken types.fix(auth): Defines missing DecodedIdToken types.Apr 17, 2020

@hiranya911hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Over to @egilmorez for doc review.

@hiranya911hiranya911 removed their assignment Apr 17, 2020

@egilmorezegilmorez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions and questions, thanks!

Comment threadsrc/auth.d.ts Outdated
auth_time: number;

/**
* The email corresponding to the user who the ID token belonged to, if available.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The email of the user to whom the ID token belonged, if available.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment threadsrc/auth.d.ts Outdated
email?: string;

/**
* Whether the email corresponding to the user who the ID token belonged to is

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest "Whether or not the email of the user to whom the ID token belonged is verified, provided the user has an email."

Are the valid values true and false?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, true or false. Done.

Comment threadsrc/auth.d.ts Outdated
iss: string;

/**
* The phone number corresponding to the user who the ID token belonged to,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest "The phone number of the user to whom the ID token belonged, if available."

Or -- can these be present tense "belongs?" That would be preferable if it is accurate.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done on both.

Comment threadsrc/auth.d.ts Outdated
phone_number?: string;

/**
* The photo URL corresponding to the user who the ID token belonged to,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest "The photo URL for the user to whom the ID token belonged..."

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DecodedIDToken interface is missing fields

3 participants

@bojeil-google@hiranya911@egilmorez