Uh oh!
There was an error while loading. Please reload this page.
Rectified issues in comments for NotificationMessagePayload - #879
Conversation
googlebot
commented
May 7, 2020
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
VPanjeta
commented
May 7, 2020
@googlebot I signed it! |
googlebot
commented
May 7, 2020
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
lahirumaramba
commented
May 7, 2020
| * | ||
| * **Platforms:** Android | ||
| * The sound to be played when the device receives the | ||
| * notification. |
There was a problem hiding this comment.
/**
* The sound to play when the device receives the notification. Supports
* "default" or the filename of a sound resource bundled in the app. Sound files
* must reside in `/res/raw/`.
* * **Platforms:** Android
*/
I think the docs from #820 might be more suitable here. I will leave @egilmorez to confirm.
VPanjeta
commented
May 11, 2020
Ok since it is already present in #820 . Closing this for now. |
lahirumaramba
commented
May 11, 2020
VPanjeta
commented
May 11, 2020
@lahirumaramba Made the changes as expected. Do let me know if anything else is needed. |
| * If specified and a notification with the same tag is already being shown, | ||
| * the new notification replaces the existing one in the notification drawer. | ||
| * | ||
| * The sound to be played when device receives a notification. Supports |
There was a problem hiding this comment.
Since we are using articles everywhere else (instead of the extra-concise style that omits them), we should probably use them here too:
"The sound to be played when the device receives a notification. Supports
* * "default" for the default notification sound of the device"
egilmorez
left a comment
There was a problem hiding this comment.
Thanks for sending! LG with one nit regarding articles.
VPanjeta
commented
May 11, 2020
@egilmorez Sorry for having some semantic/grammatical errors. English isn't my native language. Pushed a commit after adding articles to the comments. Hopefully that fixes your concerns. |
lahirumaramba
left a comment
There was a problem hiding this comment.
Thank you @VPanjeta !
LGTM!
The comments regarding the
NotificationMessagePayloadwere not correct. They were placed with different options.The comment related to
tagwas attached tosoundandtagdid not have any comment attached.Had an issue understanding the payload the first time I opened the installed directory to go through the payload of
sendToDevice