Skip to content

Implementation for Evaluating Condition and Custom Signals Server Side Remote Config - #824

Merged
rathovarun1032 merged 16 commits into
ssrcfrom
ssrc-evaluate
Nov 15, 2024
Merged

Implementation for Evaluating Condition and Custom Signals Server Side Remote Config#824
rathovarun1032 merged 16 commits into
ssrcfrom
ssrc-evaluate

Conversation

@rathovarun1032

@rathovarun1032rathovarun1032 commented Oct 30, 2024

Copy link
Copy Markdown

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@rathovarun1032rathovarun1032 changed the title Ssrc evaluateImplementation for Evaluating Condition and Custom Signals Server Side Remote ConfigNov 4, 2024
@rathovarun1032
rathovarun1032 marked this pull request as ready for review November 4, 2024 14:20
erikeldridge
erikeldridge approved these changes Nov 14, 2024
View reviewed changes

@erikeldridgeerikeldridge left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

To over-communicate, I'm approving this from the perspective of someone familiar with this feature. I expect this change will also be reviewed by an Admin SDK platform owner before merging into the main branch.

Comment threadfirebase_admin/remote_config.py Outdated
Comment threadfirebase_admin/remote_config.py Outdated
Comment threadfirebase_admin/remote_config.py Outdated
Comment threadfirebase_admin/remote_config.py Outdated
Comment threadfirebase_admin/remote_config.py Outdated
Comment threadfirebase_admin/remote_config.py Outdated
Comment threadfirebase_admin/remote_config.py Outdated
Comment threadtests/test_remote_config.py Outdated
Comment threadtests/test_remote_config.py Outdated
Comment threadtests/testutils.py Outdated
@rathovarun1032
rathovarun1032 merged commit 6f9591b into ssrcNov 15, 2024
pijushcs pushed a commit that referenced this pull request Jan 8, 2025
@rathovarun1032Pijush Chakraborty
Implementation for Evaluating Condition and Custom Signals Server Sid…
ccb186a
…e Remote Config (#824)
* Added implemenation of evaluate function
* Improvement
* Add farmhash to extension whitelist pkg
* Replace farmhash to hashlib
* Added unit testcase
* removed lint error
* add mock test
* resolve lint comments
* Fixed bug
* Added fixes
* Added fixe
* Added fix for lint
* Changed structure of test
* Added fix for comments
* Added fix for comments
---------
Co-authored-by: Varun Rathore <varunrathore@google.com>
pijushcs pushed a commit that referenced this pull request Feb 12, 2025
@rathovarun1032Pijush Chakraborty
Implementation for Evaluating Condition and Custom Signals Server Sid…
bcc261f
…e Remote Config (#824)
* Added implemenation of evaluate function
* Improvement
* Add farmhash to extension whitelist pkg
* Replace farmhash to hashlib
* Added unit testcase
* removed lint error
* add mock test
* resolve lint comments
* Fixed bug
* Added fixes
* Added fixe
* Added fix for lint
* Changed structure of test
* Added fix for comments
* Added fix for comments
---------
Co-authored-by: Varun Rathore <varunrathore@google.com>
pijushcs pushed a commit that referenced this pull request Feb 12, 2025
@rathovarun1032Pijush Chakraborty
Implementation for Evaluating Condition and Custom Signals Server Sid…
345412b
…e Remote Config (#824)
* Added implemenation of evaluate function
* Improvement
* Add farmhash to extension whitelist pkg
* Replace farmhash to hashlib
* Added unit testcase
* removed lint error
* add mock test
* resolve lint comments
* Fixed bug
* Added fixes
* Added fixe
* Added fix for lint
* Changed structure of test
* Added fix for comments
* Added fix for comments
---------
Co-authored-by: Varun Rathore <varunrathore@google.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lahirumarambalahirumarambaAwaiting requested review from lahirumaramba
1 more reviewer
@erikeldridgeerikeldridgeerikeldridge approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rathovarun1032@erikeldridge