Uh oh!
There was an error while loading. Please reload this page.
Add mergeConfig option to opt out of implicit config object merging - #536
Add mergeConfig option to opt out of implicit config object merging#536swseverance wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a mergeConfig option to Superstatic, allowing users to provide a configuration object that is not merged with existing superstatic.json or firebase.json files. The changes include updates to the configuration loader, middleware options, and documentation, along with new unit tests. Feedback identifies a potential bug where mergeConfig: false incorrectly handles file paths, and suggests a logic adjustment and an additional test case to ensure correct behavior.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
5e3b3c8 to
5d0f0ceCompareandersonaddo
commented
Jul 17, 2026
@swseverance hello! |
When a plain object is passed as config via the programmatic API, superstatic merges it with any superstatic.json or firebase.json found on disk. Add mergeConfig: false to use the provided object as-is. This only affects programmatic usage — the CLI always uses the specified config file directly and was never subject to merging. Resolvesfirebase#503
5d0f0ce to
c76dc7aCompare
When a plain object is passed as config via the programmatic API, superstatic merges it with any superstatic.json or firebase.json found on disk. Add mergeConfig: false to use the provided object as-is.
This only affects programmatic usage — the CLI always uses the specified config file directly and was never subject to merging.
Resolves#503