gem: disable making temporaries for VariableIndexs - #195
Merged
Conversation
ksagiyam
marked this pull request as ready for review
October 16, 2025 18:54
pbrubeck
approved these changes
Oct 17, 2025
pbrubeck
left a comment
There was a problem hiding this comment.
I don't understand this in depth, but this clearly seems like the right fix. Thanks
Author
|
Thanks. |
ksagiyam
added a commit
that referenced
this pull request
Oct 24, 2025
* Bump version number * gem: disable making temporaries for VariableIndexs (#195) --------- Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for firedrakeproject/firedrake#4658.
firedrakeproject/tsfc#317 attempted to use temporaries for complex index expressions involving
VariableIndexs, but it seems it requires more work to make in-loop temporaries work, so disable making temporaries for index expressions for now.