Tabulate high-order expansion derivatives by recurrence - #256
Merged
Conversation
Author
|
Updated verification after the HCT degree-14 follow-up. What changed:
Verification:
AI tool used: Codex. |
pbrubeck
commented
Jul 10, 2026
pbrubeck
commented
Jul 13, 2026
pbrubeck
commented
Jul 13, 2026
rckirby
reviewed
Jul 13, 2026
rckirby
left a comment
There was a problem hiding this comment.
After we resolve the comments, I think this makes sense to do. The derivative matrices are kind of clunky and tend to go unstable at high order.
pbrubeck
force-pushed
the
pbrubeck/deriv-recurrence
branch
5 times, most recently
from
July 20, 2026 11:04
71d2aa2 to
090475b
Compare
pbrubeck
force-pushed
the
pbrubeck/deriv-recurrence
branch
from
July 20, 2026 11:28
090475b to
7542778
Compare
pbrubeck
force-pushed
the
pbrubeck/deriv-recurrence
branch
from
July 20, 2026 14:43
100e11f to
ea4d7a0
Compare
rckirby
approved these changes
Jul 21, 2026
rckirby
left a comment
There was a problem hiding this comment.
Thanks, I think this makes a lot of sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes firedrakeproject/firedrake#4152
Summary
Tests
AI tool used: Codex.