Changes to FIAT to enable FUSE - #265
Open
indiamai wants to merge 14 commits into
Open
Conversation
indiamai
marked this pull request as ready for review
August 6, 2026 12:54
dham
requested changes
Aug 11, 2026
Comment on lines
+297
to
+299
| class CellBackend(Enum): | ||
| FIAT = 1 | ||
| FUSE = 2 |
Member
There was a problem hiding this comment.
Could use a string enum here: https://docs.python.org/3/library/enum.html#enum.StrEnum
Suggested change
| class CellBackend(Enum): | |
| FIAT = 1 | |
| FUSE = 2 | |
| class CellBackend(enum.StrEnum): | |
| FIAT = 'FIAT' | |
| FUSE = 'FUSE' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal changes to enable FUSE in FIAT.
Key changes:
use_fuseand FuseElement.use_fuseis derived from the Firedrake mesh.as_cellinto FIAT from UFL so that we can delegate to fuse creation as appropriate. Falls back to UFL implementation in all other cases.Tested in firedrake on Firedrake PR #5276 and FUSE main sits on this branch.