Leave the point indices free in dual evaluation - #288
Merged
Conversation
dual_evaluation returns (evaluation, point_indices, basis_indices), summing only over the value shape. The caller now chooses how to contract over the points, matching basis_evaluation, which already leaves the point index free. Dropping the contraction here also retires the workaround for #283. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
pbrubeck
added a commit
to firedrakeproject/firedrake
that referenced
this pull request
Aug 24, 2026
Interpolation compiles through the mode pipeline only once dual evaluation leaves the point indices free, which lives on the FIAT companion branch. CI installs the pinned FIAT release, so without this every interpolation raises "not enough values to unpack (expected 3, got 2)". Drop this commit once firedrakeproject/fiat#288 merges. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
connorjward
approved these changes
Aug 24, 2026
connorjward
left a comment
There was a problem hiding this comment.
Assuming that tests pass and this doesn't negatively impact performance (by much) then this seems very nice.
connorjward
requested changes
Aug 24, 2026
connorjward
left a comment
There was a problem hiding this comment.
Actually wait, shouldn't we be modifying the stop_at code too?
Author
Sure, I should do that here. |
pbrubeck
force-pushed
the
pbrubeck/interp-spectral
branch
from
August 24, 2026 16:22
8719902 to
cec22af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #283 by making
dual_evaluationno longer have to sum-factorise internallydual_evaluationreturns(evaluation, point_indices, basis_indices), summing only over the value shape.TSFC now chooses how to contract over the points, matching
basis_evaluation, which already leaves the point index free.