Stash compiled kernels on the form to save recompiling - #248
Merged
Conversation
Contributor
|
That looks reasonable, go ahead. |
Member
|
Yes looks fine. Note that this is different functionality from the assembly cache: we need both. |
Contributor
Author
|
@dham Sure, I wasn't suggesting this would obviate the assembly cache. |
wence-
added a commit
that referenced
this pull request
Apr 10, 2014
Save the compiled kernels in the form_data for later reuse.
sghelichkhani
added a commit
to sghelichkhani/firedrake
that referenced
this pull request
Jun 12, 2026
Drop this commit (restoring the pyadjoint-ad version pin) once dolfin-adjoint/pyadjoint#248 is merged and released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out #244 only helps in a few cases and it's much more
straightforward to stash the kernel on the form data.