Set NumberOfComponents to 3 for a VFS. - #260
Merged
Merged
Conversation
Contributor
|
Have squashed the fixup commit and used |
ctjacobs
added a commit
that referenced
this pull request
Apr 14, 2014
Set NumberOfComponents to 3 for a VFS.
connorjward
pushed a commit
that referenced
this pull request
Dec 4, 2024
…pe-inference Faster type inference in loopy codegen
hardik-corintis
added a commit
to Corintis/firedrake
that referenced
this pull request
Aug 7, 2026
Threads dtype=RealType (or the numpy-derived real dtype from scalar_type in TSFC) through every as_fiat_cell/create_element call site in firedrake and tsfc, using FIAT PR firedrakeproject#260 and FInAT's new dtype support (firedrakeproject/fiat#263). Removes the finat.element_factory.ufc_cell monkeypatch in firedrake/utils.py, which is no longer needed now that callers declare their working precision explicitly instead of relying on a globally-overridden default. Also fixes petsc_sparse's hardcoded rtol=1E-10 drop tolerance (firedrake/preconditioners/fdm.py), which is too tight for single precision: reference-cell geometry feeding into these matrices is only accurate to float32 round-off (~1e-7), so entries that should be exactly zero (e.g. in a Nedelec discrete gradient matrix) were leaking into the sparsity pattern above the fp64-tuned threshold, corrupting the exact combinatorial structure PETSc's PCBDDCNedelecSupport expects and causing test_bddc_aij_simplex[N1curl-3-False] to fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set NumberOfComponents to 3 in the pvtu file when writing a Function whose function space is a VectorFunctionSpace.
Fixes #259.