Conversation
Construct a BDM1 flux F such that div(F) == D0 where D0 is an upwind DG0 approximation to div(u*D).
Contributor
There was a problem hiding this comment.
Isn't this now supposed to work?
Contributor
Author
There was a problem hiding this comment.
Exterior facets ought to work, interior needs a little more work. I need to test Michael's latest change. Maybe next week?
wence-
added a commit
that referenced
this pull request
May 2, 2014
Add a test of upwind flux construction. Construct a BDM1 flux F such that div(F) == D0 where D0 is an upwind DG0 approximation to div(u*D).
connorjward
pushed a commit
that referenced
this pull request
Dec 4, 2024
finatinterface: set hexahedral_tcp = interval x interval x interval
pbrubeck
added a commit
that referenced
this pull request
Aug 20, 2026
The TSFC changes here need the GEM changes in the FIAT stack firedrakeproject/fiat#282 -> #284 -> #281, whose head carries all three. Install it over the one pyproject.toml resolves from main, so that CI exercises both halves together. Revert this commit once the FIAT stack lands. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
pbrubeck
added a commit
that referenced
this pull request
Aug 22, 2026
The TSFC changes here need the GEM changes in the FIAT stack firedrakeproject/fiat#282 -> #284 -> #281 -> #286, whose head carries all four. Install it over the one pyproject.toml resolves from main, so that CI exercises both halves together. Revert this commit once the FIAT stack lands. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Construct a BDM1 flux F such that div(F) == D0 where D0 is an upwind DG0
approximation to div(u*D).