Cap islpy below 2026.2 on release - #5378
Merged
Merged
Conversation
islpy 2026.2 removed the implicit conversion of a BasicSet to a Set, so loopy 2025.2 raises AttributeError from count_insn_runs when it reaches BasicSet.make_disjoint, and every flop count in the test suite fails. loopy has released nothing since, so hold islpy at the last version that still converts. Lift the cap once loopy releases the fix. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
connorjward
requested changes
Aug 24, 2026
pbrubeck
added a commit
that referenced
this pull request
Aug 25, 2026
The latest release breaks loopy. --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
pbrubeck
added a commit
that referenced
this pull request
Aug 26, 2026
The latest release breaks loopy. --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
nwng04
pushed a commit
that referenced
this pull request
Aug 27, 2026
The latest release breaks loopy. --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
islpy2026.2 removed the implicit conversion of aBasicSetto aSet.loopy2025.2 — the newest release, and whatloopy>2024.1resolves to — callsBasicSet.make_disjoint()incount_insn_runs, so every flop count in the test suite fails:islpy 2026.2.1 was published on 2026-08-22, after the last CI run on this branch, so
releasehas not hit this yet — but the next run will, and so will anyone installing a released Firedrake today.maintakes loopy from git instead (#5377). That is not appropriate here, where every dependency is a released version, so cap islpy at the last one that still converts. With islpy 2026.1 and loopy 2025.2,tests/tsfcis 369 passed locally (run againstmain's copy of those tests, which is the same loopy/islpy interaction).Lift the cap once loopy makes a release containing the explicit
to_set().AI was used in preparing this contribution (Claude Code).
🤖 Generated with Claude Code