Conversation
Installs firedrakeproject/fiat#291 over the pinned FIAT so Firedrake CI exercises the deterministic free-index ordering that PR introduces. The install runs after Firedrake itself, then clears the caches, because the change alters generated code and any tabulation cached beforehand is stale. Drop this commit once firedrakeproject/fiat#291 has merged. This branch carries nothing else, so it must never merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway branch. It exists only to run Firedrake CI against
firedrakeproject/fiat#291, which makes GEM order free indices by creation
rather than by memory address. Do not merge it.
The single commit installs that FIAT branch over the pinned version, after
Firedrake is installed, and then runs
firedrake-clean, because the changealters generated code and cached tabulations from the pinned FIAT would be
stale. Nothing outside
.github/is touched, and once firedrakeproject/fiat#291 merges thisbranch has no content left, so it should be closed rather than merged.
What the tick is worth: FIAT #291 changes the loop nest of every generated
kernel, so the point is to confirm it is a reordering and not a regression.
Locally, on
tests/{tsfc,multigrid,macro}, a paired run (both variants warmed,separate caches, failures compared by name) gave identical failure sets with
and without the change.
Assisted by Claude Code (Claude Opus 5).