Otherwise subdomain - #829
Merged
Merged
Conversation
| kwargs["iterate"] = index | ||
| decoration = {"exterior_facet_top": op2.ON_TOP, | ||
| "exterior_facet_bottom": op2.ON_BOTTOM}[integral_type] | ||
| kwargs["iterate"] = decoration |
Contributor
Author
There was a problem hiding this comment.
I've moved the "decoration" bit out of the measure_set method to here (which is the only place it's used).
wence-
force-pushed
the
otherwise-subdomain
branch
2 times, most recently
from
July 18, 2016 10:16
91d1b13 to
9411186
Compare
Provide a single point of entry for getting the measure set corresponding to a particular integral. We now always ask the measure for a measure_set providing the integral type, subdomain_id, and for correct treatment of "otherwise" subdomains, all the explicitly enumerated integer subdomain ids.
The "otherwise" subdomain that appears in preprocessed forms is not an integral over all mesh entities, but rather over all mesh entities that are not caught by any explicitly enumerated subdomains. If the form contains no explicit subdomain ids, then "otherwise" = "everywhere". If not, "otherwise" = "everywhere" - set(explicit subdomain). To implement this, we pass the list of explicitly provided subdomain ids to measure_set and use this to construct the appropriate "complement" subset. Fixes #797 and #281.
wence-
force-pushed
the
otherwise-subdomain
branch
from
July 18, 2016 12:43
2d80e15 to
183418a
Compare
Contributor
Author
|
Have added docstrings, I think this is good to go. |
wence-
force-pushed
the
otherwise-subdomain
branch
from
July 19, 2016 12:11
a1686ae to
6943671
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctly implements treatment of "otherwise" in integrals. Fixes #281 and fixes #797. Suggestions for further tests and/or better refactoring welcome.