Uh oh!
There was an error while loading. Please reload this page.
Accept JsonSlabs files in publish endpoint - #696
Conversation
canova
left a comment
There was a problem hiding this comment.
Looks reasonable to me! I have 1 small question regarding very short jsons, but happy to go either way. Let me know what you think!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
fcbbb93 to
ccc4f4cComparecanova
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
It's been a while since we did a deploy for the profiler-server though. It might make sense to do a deployment before this so we make sure that we don't regress anything in the meantime. I'll try to deploy today or tomorrow.
The next commit will add a dependency to json-slabs, which is an ESM-only module and needs to be added to transformIgnorePatterns so that Jest can handle it. Without this change, transformIgnorePatterns would not apply to anything under node_modules (because .babelrc stops applying in any directory that has a package.json). Using the name babel.config.json turns it into a "project-wide" configuration: https://babeljs.io/docs/config-files#project-wide-configuration
Uh oh!
There was an error while loading. Please reload this page.
Changes: - Accept JsonSlabs files in publish endpoint (#696) - Dependency updates
In the profiler front-end we want to start uploading profiles in the JsonSlabs (JSLB) binary container format, so that we don't have to spend time encoding long arrays of numbers to JSON strings.
The server currently rejects such files because it scans for an opening curly brace. This PR adapts the validation code to allow JSLB files.