Uh oh!
There was an error while loading. Please reload this page.
Add nativeSymbols functionSize column. - #4226
Merged
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@## main #4226 +/- ##
=======================================
Coverage ? 88.51% =======================================
Files ? 282 Lines ? 24757 Branches ? 6613 =======================================
Hits ? 21913 Misses ? 2642 Partials ? 202 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
canova
approved these changes
Sep 22, 2022
Uh oh!
There was an error while loading. Please reload this page.
In order to know how much assembly code to display for a native symbol in the assembly view, we need to know how large the function is, i.e. how many bytes of machine code in contains. In the assembly view we want to display the entire function, not just the assembly code up until the highest instruction address that we've seen for that function. The symbolication API now gives us this information, as of mstange/profiler-get-symbols@e8649bf . So we can have this information for local builds and when using samply. The Mozilla symbolication API does not return this information yet, so we need to support "null" values with some kind of fallback. This commit gets the information from the symbolication result, if present, and forwards it into the nativeSymbols table. We also bump the processed profile version and add an upgrader.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to know how much assembly code to display for a native symbol in the assembly view, we need to know how large the function is, i.e. how many bytes of machine code in contains.
In the assembly view we want to display the entire function, not just the assembly code up until the highest instruction address that we've seen for that function.
The symbolication API now gives us this information, as of mstange/profiler-get-symbols@e8649bf . So we can have this information for local builds and when using samply. The Mozilla symbolication API does not return this information yet, so we need to support "null" values with some kind of fallback.
This commit gets the information from the symbolication result, if present, and forwards it into the nativeSymbols table. We also bump the processed profile version and add an upgrader.