Uh oh!
There was an error while loading. Please reload this page.
Update GCMinor profile markers to remove object group information and move calculation of tenuring allocation rate to the browser - #5440
Conversation
This data relates to ObjectsGroups, a feature that was removed in December 2020 in bug 1673553. Since then this data has not been present in profiles.
… of the profile data. Remove the calculation from the profiler. Remove the cell count allocation rate as it's not that useful, leaving the byte count rate only. The corresponding browser change is: https://bugzilla.mozilla.org/show_bug.cgi?id=1963597
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #5440 +/- ##
==========================================
- Coverage 86.03% 86.03% -0.01%
==========================================
Files 312 312 Lines 30365 30354 -11 Branches 8299 8293 -6 ==========================================
- Hits 26126 26115 -11 + Misses 3645 3644 -1 - Partials 594 595 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ); | ||
| } | ||
| if (evictTimeMS) { | ||
| if (nursery.strings_tenured && nursery.strings_deduplicated) { |
There was a problem hiding this comment.
What's the plan for the older profiles that don't have these values?
I think you told me that it's OK they don't show the data because the calculation was kind of wrong anyway, but can you please confirm that?
There was a problem hiding this comment.
Older profiles will not show this field, but they already didn't show this since a change in December 2021 broke this calculation.
With this change new profiles will show the field and old profiles will be unaffected (i.e. they still won't have the field).
Changes: [Jon Coppeard] Update GCMinor profile markers to remove object group information and move calculation of tenuring allocation rate to the browser (#5440)
As per commit messages, this removes handling of object group data that has not been present in profile data for years and updates tenuring allocation information so it's calculated in the browser rather than in the profiler. This change only affects GCMinor markers.