Uh oh!
There was an error while loading. Please reload this page.
Change the tests that check co2 values so they don't fail on every co2 dependency update - #5475
Merged
Merged
Conversation
Previously we had a specific value for the expected co2 number, which was problematic because whenever we had to upgrade the co2 package, we had to update these values too. It's a small annoyance, but it can be still annoying, especially you had to stop what you were doing and just update the values of the tests. So instead now we expect any values for these tests expectations. That way we can upgrade the co2 package without problem!
Similar reason to the previous commit, but we had to change this snapshot test into a more granular test that checks individual fields because it's not very easy to get the html and then replace all the text contents, similar to `getBy*`. This is a lot safer to do instead. We could simply get the html content with `.innerHtml` but it doesn't pretty print the DOM tree, which makes it very difficult to understand the changes. There is a `prettyDOM` method in testing-library, but it's added for debugging purposes and not really for testing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #5475 +/- ##
=======================================
Coverage 86.03% 86.03% =======================================
Files 312 312 Lines 30364 30364 Branches 8296 8296 =======================================
Hits 26125 26125 Misses 3644 3644 Partials 595 595 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
julienw added a commit
that referenced
this pull request
Jun 10, 2025
Here are the changes: [Julien Wajsberg] Fix the compare view when using the same profile in both entries (#5469) [Nazım Can Altınova] Change the tests that check co2 values so they don't fail on every co2 dependency update (#5475) [Julien Wajsberg] Ignore the Symbol Store database cache when the user presses the resymbolication button (#5479) [Markus Stange] In the profile format, store a shared stringArray for all threads (#5481)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to do that for a while but finally got around to it. The latest PR that we had to update the expectations was #5474. It's not a huge thing, but it's distracting enough that triggers a context switch. So this PR changes there parts to make sure that the tests don't fail on every co2 package update
I replaced the snapshot test with a more granular test. Technically there were ways to keep the snapshot tests by doing some hacky things, but I didn't want to do them. See the commit message for more info.