Skip to content

Add a menu to copy the Marker Table as text - #5732

Merged
canova merged 1 commit into
firefox-devtools:mainfrom
arai-a:table-copy
Jan 8, 2026
Merged

Add a menu to copy the Marker Table as text#5732
canova merged 1 commit into
firefox-devtools:mainfrom
arai-a:table-copy

Conversation

@arai-a

Copy link
Copy Markdown
Contributor

Fixed#5731

This adds a button to the Marker Table settings bar, which shows a context menu that provides the following:

  • copy as plain text
  • copy as Markdown

(not sure if Markdown is actually necessary. If not, it can be simplified to just a single button that copies as plain text)

the plain text copies the table in the following style:

 Start Duration Name Details
0.002s Process Priority priority: BACKGROUND
0.002s unknown Awake
0.002s 603.25us Runnable TriggerPollJSSamplingOnMainThread - priority: Normal (4) task: 4d9c1b1537e9fcf80

the Markdown copies the table in the following style:

| Start | Duration | Name | Details |
|--------:|---------:|------------------------:|---------|
| 0.002s | | Process Priority | priority: BACKGROUND |
| 0.002s | unknown | Awake | |
| 0.002s | 603.25us | Runnable | TriggerPollJSSamplingOnMainThread - priority: Normal (4) task: 4d9c1b1537e9fcf80 |
copy-table

@arai-a
arai-a requested a review from a team as a code ownerDecember 23, 2025 12:34
@canova
canova self-requested a review December 23, 2025 13:25

@canovacanova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like the idea of being able to copy the table!

One thing I noticed is that it is hanging for a long time if the table is huge and if there is no filtering applied to it. Normally, we virtualize this table, so it might look like we don't have a lot sometimes, but for large profile it might be too many marker lines.

Maybe we can have an upper limit like const MAX_COPY_ROWS = 10000, and show users a warning that the rest is ommitted. What do you think?;

Comment threadsrc/test/components/__snapshots__/MenuButtons.test.tsx.snap Outdated
Comment threadsrc/test/components/MarkerTable.test.tsx

lines.push([
data.start,
duration.replace(/μ/g, 'u'),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we replace μ here? Are unicode chars a problem?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because "μ" is wider than other ASCII characters (at least for me) and that breaks the alignment of the table

Comment threadsrc/components/marker-table/index.tsx Outdated
Comment threadsrc/components/shared/MarkerSettings.tsx Outdated
Comment threadlocales/en-US/app.ftl
Comment threadsrc/components/marker-table/index.tsx Outdated
Comment threadsrc/components/marker-table/index.tsx
this._getMarkerLabel = getMarkerLabel;
}

copyTable = (format: string) => {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this function inside src/profile-logic/marker-data.ts. I think this is a function that's worth extracting outside of the react component. (not the copy() call, but the table building logic)

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is heavily tied to the MarkerTree class, which is local to MarkerTable component.
especially the marker handling, zeroAt, the column alignment etc are specific to the file and they depends on the memoization, and also the state map defined there.

So, the entire logic cannot be moved, and splitting a part of the logic will make it harder to follow.

Comment threadsrc/components/shared/MarkerSettings.css Outdated
@arai-a

Copy link
Copy Markdown
ContributorAuthor

I forgot to apply the upper limit.
I'll address that part shortly

@codecov

codecovBot commented Jan 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.25287% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.67%. Comparing base (1a808fe) to head (24dc2f2).
⚠️ Report is 38 commits behind head on main.

Files with missing linesPatch %Lines
src/components/shared/MarkerSettings.tsx91.17%3 Missing ⚠️
src/components/marker-table/index.tsx95.34%2 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #5732 +/- ##
==========================================
+ Coverage 85.64% 85.67% +0.02% 
==========================================
Files 313 314 +1 Lines 31013 31100 +87 Branches 8535 8469 -66 ==========================================
+ Hits 26562 26644 +82 - Misses 4021 4026 +5 
Partials 430 430 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@canovacanova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks pretty good to me. I have some small nits, but otherwise we can land this after them.

(I was also going to suggest rebasing and fixing the prettier warnings with yarn prettier-fix but it looks like you already did it)

Comment threadsrc/components/marker-table/index.tsx Outdated
Comment threadsrc/components/marker-table/index.tsx Outdated

@canovacanova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@canova
canova merged commit 87cac64 into firefox-devtools:mainJan 8, 2026
22 checks passed
@canovacanova mentioned this pull request Jan 27, 2026
canova added a commit that referenced this pull request Jan 27, 2026
Lots of exciting changes 🎉:
[arai-a] Put radio buttons into labels (#5738)
[DaniPopes] Update comment for "unique-string" (#5741)
[Karan Pradhan] Hide tooltip filter button in non-sticky tooltips and
add hideFilterButton tests (#5718)
[arai-a] Add a menu to copy the Marker Table as text (#5732)
[arai-a] Make the entire list item clickable for the "Full Range"
(#5742)
[Markus Stange] Move symbol table demangling out of SymbolStore into
SymbolProvider (#5746)
[Markus Stange] Remove SVG asset imports from profile-data.ts (#5747)
[arai-a] Do not apply sticky tooltip on double click (#5754)
[arai-a] Skip the ChartCanvas redraw on the Viewport's internal default
state usage (#5744)
[Markus Stange] Stop blindly extracting uint8array.buffer after calling
compress() (#5753)
[Markus Stange] In the assembly view state, refer to the current symbol
by index (#5755)
[Markus Stange] Fix "scroll to hotspot" functionality in the source view
+ assembly view (#5759)
[Markus Stange] Keep the colorField markerSchema field when processing
profiles in the gecko format (#5760)
[Markus Stange] Implement dark mode (#5740)
[Markus Stange] Fix light-mode colors (#5765)
[Markus Stange] Tweak dark mode colours. (#5767)
[Nazım Can Altınova] Enable some basic type-aware lints (#5775)
[Markus Stange] Allow seeing different assembly code for the same
function (#5349)
[fatadel] Refine tree view a11y (#5779)
[fatadel] Align double-click behavior of stack chart with flame graph
(#5782)
[Markus Stange] Split gz.ts properly into node and browser variants
(#5764)
[Markus Stange] Simplify and optimize the computation of per-call-node
line and address timings (#5770)
[Nazım Can Altınova] Move the dark mode toggle to devtools console
(#5783)
[Nazım Can Altınova] 🔃 Sync: l10n -> main (Jan 27, 2026) (#5785)
[Nazım Can Altınova] Improve Chrome importer marker payload logic
(#5717)
[Markus Stange] Add a Focus Self transform (#5774)
[Nazım Can Altınova] Enable the Turkish locale in production (#5786)
And huge thanks to our localizers 🎉 :
be: Mikalai Udodau
de: Ger
de: Michael Köhler
el: Jim Spentzos
en-CA: chutten
en-CA: Saurabh
en-GB: Ian Neal
en-GB: Saurabh
es-CL: ravmn
fy-NL, nl: Fjoerfoks
fr: Skywarp
fr: Théo Chevalier
fur: Fabio Tomat
fy-NL: Fjoerfoks
ia: Melo46
it: Francesco Lodolo [:flod]
nl: Fjoerfoks
nl: Mark Heijl
pt-BR: Marcelo Ghelman
ru: berry
ru: Valery Ledovskoy
sv-SE: Andreas Pettersson
tr: Grk
zh-CN: Olvcpr423
zh-CN: wxie
zh-TW: Pin-guang Chen
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the Marker Table copyable as text

3 participants

@arai-a@canova@flodolo