Skip to content

Update the docsify package that's used in the user documentation - #5872

Merged
canova merged 2 commits into
firefox-devtools:mainfrom
canova:update-docsify
Mar 2, 2026
Merged

Update the docsify package that's used in the user documentation#5872
canova merged 2 commits into
firefox-devtools:mainfrom
canova:update-docsify

Conversation

@canova

Copy link
Copy Markdown
Member

We use docsify in the user documentation. It looks like our plugin has been out of date for a while.
This PR:

  • Removes the unused ga docsify plugin. We stopped using google analytics a very long time ago. But it looks like the ga docsify plugin was still loaded even though it wasn't used.
  • Updates the docsify plugin to its latest released version, v4.13.1. But it looks like this PR is not in this release yet: fix: escape HTML in search keywords and trim sidebar id docsifyjs/docsify#2586 This PR also cherry picks the changes and manually applies on top of v4.13.1.

But apart from this, I'm not happy with the docsify plugin overall. The whole process is very tricky and we always had to manually patch it. Ideally we should switch off to a better maintained plugin. I'll file an issue about that one.

canova added 2 commits March 2, 2026 13:50
We stopped using google analytics a very long time ago. But it looks
like the ga docsify plugin was still loaded even though it wasn't used.
This commit removes this plugin
This commit updates the docsify plugin to its latest released version,
v4.13.1. But it looks like this PR is not in this release yet:
docsifyjs/docsify#2586
Since it's nice to have it, these minified JS code has this PR applied
as well.
@codecov

codecovBot commented Mar 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.56%. Comparing base (806adbc) to head (19aa5e9).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #5872 +/- ##
=======================================
Coverage 85.56% 85.56% =======================================
Files 319 319 Lines 31499 31499 Branches 8705 8697 -8 =======================================
Hits 26953 26953 Misses 4115 4115 Partials 431 431 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@canova
canova merged commit 5b266f5 into firefox-devtools:mainMar 2, 2026
21 checks passed
@canovacanova mentioned this pull request Mar 3, 2026
canova added a commit that referenced this pull request Mar 3, 2026
Changes:
[fatadel] Fix crash when nativeSymbol index is out of bounds in assembly
view (#5850)
[depfu[bot]] Update all Yarn dependencies (2026-02-25) (#5859)
[Nazım Can Altınova] Fix the color of dark mode back arrow svg (#5863)
[fatadel] Force canvas redraw when system theme changes (#5861)
[Nazım Can Altınova] Fix unhandled promise rejection in
setupInitialUrlState (#5864)
[fatadel] Persist selected marker in URL and show sticky tooltip on load
(#5847)
[Markus Stange] Implement the "collapse resource" transform with the
help of the "collapse direct recursion" transform. (#5824)
[Markus Stange] Bump rollup from 2.79.2 to 2.80.0 (#5868)
[Markus Stange] Remove async attribute from module script tag. (#5870)
[Nazım Can Altınova] Update the docsify package that's used in the user
documentation (#5872)
[Markus Stange] Share stackTable, frameTable, funcTable, resourceTable
and nativeSymbols between threads (#5482)
[Nazım Can Altınova] Escape CSS URLs that are coming from profiles
(#5874)
[fatadel] Update home page message for the other browser case (#5866)
[fatadel] Add support for ternaries in marker labels (#5857)
[Markus Stange] Reduce allocations for getStackLineInfo +
getStackAddressInfo (#5761)
And special thanks to our localizers:
de: Ger
fy-NL: Fjoerfoks
it: Francesco Lodolo [:flod]
nl: Fjoerfoks
ru: berry
ru: Valery Ledovskoy
zh-TW: Pin-guang Chen
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@canova@mstange@fatadel