Uh oh!
There was an error while loading. Please reload this page.
Restore 15px fallback for TimelineMarkersMemory height - #5981
Merged
fatadel merged 1 commit intoApr 28, 2026
Conversation
The fallback was dropped in firefox-devtools#5944 when the rule moved from TrackMemory.css to TrackCounter.css. TrackThread still renders TimelineMarkersMemory directly on the main thread when a process has no Memory counter track, and that row is not a descendant of any TrackCounter wrapper, so --markers-height is undefined there. Without a fallback the var() resolves to height's initial value (auto), collapsing the row and the canvas inside it. Add the 15px fallback back so the fallback path renders at its intended height. Counter tracks are unaffected because TrackCounter sets --markers-height explicitly on the wrapper.
canova
approved these changes
Apr 28, 2026
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #5981 +/- ##
==========================================
- Coverage 85.33% 85.25% -0.09%
==========================================
Files 323 317 -6 Lines 32262 31935 -327 Branches 8895 8753 -142 ==========================================
- Hits 27532 27226 -306 + Misses 4298 4277 -21
Partials 432 432 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fatadel added a commit
that referenced
this pull request
Apr 28, 2026
Changes: [fatadel] Restore 15px fallback for TimelineMarkersMemory height (#5981)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fallback was dropped in #5944 when the rule moved from TrackMemory.css to TrackCounter.css. TrackThread still renders TimelineMarkersMemory directly on the main thread when a process has no Memory counter track, and that row is not a descendant of any TrackCounter wrapper, so --markers-height is undefined there. Without a fallback the var() resolves to height's initial value (auto), collapsing the row and the canvas inside it.
Add the 15px fallback back so the fallback path renders at its intended height. Counter tracks are unaffected because TrackCounter sets --markers-height explicitly on the wrapper.