Skip to content

Switch from max-height to maxHeight in JSX style={{...}}. - #5990

Merged
mstange merged 1 commit into
firefox-devtools:mainfrom
mstange:push-qrwrwozwqkpr
May 5, 2026
Merged

Switch from max-height to maxHeight in JSX style={{...}}.#5990
mstange merged 1 commit into
firefox-devtools:mainfrom
mstange:push-qrwrwozwqkpr

Conversation

@mstange

Copy link
Copy Markdown
Contributor

Fixes#5989.

@mstange
mstange requested a review from fatadelApril 29, 2026 22:24
@codecov

codecovBot commented Apr 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.81%. Comparing base (ffeadea) to head (61e5d10).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #5990 +/- ##
=======================================
Coverage 83.81% 83.81% =======================================
Files 328 328 Lines 34253 34255 +2 Branches 9569 9572 +3 =======================================
+ Hits 28710 28712 +2 
Misses 5115 5115 Partials 428 428 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic breaks now, because endsWith is case-sensitive.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch. Updated.

@mstange
mstangeforce-pushed the push-qrwrwozwqkpr branch from 59a0d63 to 61e5d10CompareMay 4, 2026 18:32
@mstange
mstange requested a review from fatadelMay 4, 2026 18:32
@mstange
mstange merged commit cab6f4a into firefox-devtools:mainMay 5, 2026
23 checks passed
@canovacanova mentioned this pull request May 7, 2026
canova added a commit that referenced this pull request May 7, 2026
Changes:
[Markus Stange] Use custom splitter component (#4606)
[fatadel] Fix Download button text color when clicked (#5985)
[Samuel Glauser] Fix fullscreen icon size in bottom box (#5987)
[Nazım Can Altınova] Add `profiler-cli` for querying profiles (#5963)
[Nazım Can Altınova] Bump profiler cli version to 0.1.0 (#5996)
[Markus Stange] Switch from max-height to maxHeight in JSX
style={{...}}. (#5990)
[carverdamien] Fix comment about how time and duration are stored
(#5997)
[Nazım Can Altınova] Do not show console error when libnames are failed
to parse as a URL (#5993)
[Nazım Can Altınova] Fix the unnecessary stringify of Uint8Array
contents during zip profile extraction (#6004)
And special thanks to our localizers:
en-CA: chutten
en-CA: Saurabh
en-GB: Ian Neal
es-CL: ravmn
fy-NL: Fjoerfoks
ia: Melo46
nl: Mark Heijl
ru: Valery Ledovskoy
sv-SE: Andreas Pettersson
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

max-height warnings during yarn test

2 participants

@mstange@fatadel