Skip to content

Add marker handles to profiler-cli thread network - #6172

Merged
canova merged 2 commits into
firefox-devtools:mainfrom
canova:network-marker-handle
Jul 14, 2026
Merged

Add marker handles to profiler-cli thread network#6172
canova merged 2 commits into
firefox-devtools:mainfrom
canova:network-marker-handle

Conversation

@canova

@canovacanova commented Jul 13, 2026

Copy link
Copy Markdown
Member

Main | Deploy preview

Note that this depends on #6171 since it touches the schemas.txt. That PR needs to be reviewed first. Please ignore the first commit in this PR (as that belongs to that PR) and only review the second one.
The previous PR has landed.

Every request entry in thread network now has a marker handle, so a slow request can be fed straight to zoom push m-N or marker info m-N without re-finding it via thread markers. Other commands in the cli usually have marker handles if they show any markers, we didn't include that before, but it's always good to include it.

Example profile: https://share.firefox.dev/4aGPacn

pq thread network before:

[Thread: t-0 (GeckoMain) | View: Full profile | Full: 6.639s]
Network requests in thread t-0 (https://firefox.com) — 11 requests
Summary:
Cache: 0 hit, 0 miss, 11 unknown
Phase totals:
TTFB: 3.635s
Download: 626.10ms
Main thread wait: 1.551s
https://symbolication.services.mozilla.com/symbolicate/v5
200 h2 size=221.1KB duration=708.27ms
Phases: TTFB=414.43ms DL=22.913ms wait=32.476ms
https://symbolication.services.mozilla.com/symbolicate/v5
200 h2 size=1705.9KB duration=1.345s
Phases: TTFB=700.41ms DL=178.28ms wait=205.48ms
https://symbolication.services.mozilla.com/symbolicate/v5
200 h2 size=116.1KB duration=705.23ms
Phases: TTFB=298.93ms DL=39.541ms wait=113.42ms

After:

[Thread: t-0 (GeckoMain) | View: Full profile | Full: 6.639s]
Network requests in thread t-0 (https://firefox.com) — 11 requests
Summary:
Cache: 0 hit, 0 miss, 11 unknown
Phase totals:
TTFB: 3.635s
Download: 626.10ms
Main thread wait: 1.551s
m-1 https://symbolication.services.mozilla.com/symbolicate/v5
200 h2 size=221.1KB duration=708.27ms
Phases: TTFB=414.43ms DL=22.913ms wait=32.476ms
m-2 https://symbolication.services.mozilla.com/symbolicate/v5
200 h2 size=1705.9KB duration=1.345s
Phases: TTFB=700.41ms DL=178.28ms wait=205.48ms
m-3 https://symbolication.services.mozilla.com/symbolicate/v5
200 h2 size=116.1KB duration=705.23ms
Phases: TTFB=298.93ms DL=39.541ms wait=113.42ms

@canova
canova requested review from fatadel and mstangeJuly 13, 2026 09:12
@codecov

codecovBot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.49%. Comparing base (4cf61c8) to head (758a0ec).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #6172 +/- ##
=======================================
Coverage 83.49% 83.49% =======================================
Files 344 344 Lines 36868 36868 Branches 10343 10334 -9 =======================================
Hits 30782 30782 Misses 5659 5659 Partials 427 427 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@canova
canovaforce-pushed the network-marker-handle branch 3 times, most recently from 4979c75 to f11da05CompareJuly 13, 2026 11:47
Every request entry in `thread network` now carries a marker handle, so
a slow request can be fed straight to `zoom push m-N` or `marker info
m-N` without re-finding it via `thread markers`. Threads the markerMap
through collectThreadNetwork.

@fatadelfatadel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@canova
canova enabled auto-merge (squash) July 14, 2026 08:54
@canova
canova merged commit 625714a into firefox-devtools:mainJul 14, 2026
21 checks passed
@canovacanova mentioned this pull request Jul 21, 2026
canova added a commit that referenced this pull request Jul 21, 2026
Changes:
[Sky Ning] Skip preview links for non-main PRs (#6161)
[spokodev] fix(gecko-upgrade): don't crash on a counter with empty
sample_groups (#6160)
[fatadel] Show counter values over time in profiler-cli (#6136)
[Markus Stange] Make profile-conversion snapshots more compact and
meaningful (#6152)
[Markus Stange] More typed arrays: sample + counter times, some
frametable columns (#6139)
[Nazım Can Altınova] Only render a marker url field as a link when the
whole value is a URL (#6163)
[fatadel] Show each counter's owning process in profiler-cli (#6164)
[Nazım Can Altınova] Document the pre-existing thread info and network
JSON schemas in the cli (#6171)
[Markus Stange] Copy column contents in
getRawSamplesTableBuilderFromExisting for consistency (#6168)
[Markus Stange] Convert eligible columns to typed arrays when outputting
from profiler-edit (#6167)
[Markus Stange] Remove unused samples.thread column (#6151)
[Markus Stange] Fixed botched merge which broke 'yarn ts' (#6174)
[Nazım Can Altınova] Add marker handles to `profiler-cli thread network`
(#6172)
[Markus Stange] Update json-slabs 0.3.0 → 0.4.0 (major) (#6176)
[Nazım Can Altınova] Surface network activity across profiler-cli
(#6175)
[Nazım Can Altınova] Add `profile meta` command to profiler-cli (#6177)
[Markus Stange] Allow raw marker table's `startTime` and `endTime`
columns to be Float64Array (#6169)
[nightcityblade] Fix light theme text selection colors (#6186)
[Nazım Can Altınova] Import source map URLs from Chrome DevTools traces
(#6190)
[Nazım Can Altınova] Rename yarn `build-profiler-cli` script to
`build-cli` (#6191)
[Nazım Can Altınova] Migrate husky to version 9 (#6201)
[Nazım Can Altınova] Fix horizontal overflow when the transform
navigator is long (#6199)
[fatadel] Add a 'hexadecimal' marker schema field format (#6197)
[Nazım Can Altınova] Bump source-map to 0.8.0 and remove the old type
workaround (#6202)
[Nazım Can Altınova] 🔃 Sync: l10n -> main (July 21, 2026) (#6209)
And special thanks to our localizers:
fr: parmegiani.thomas
fr: Théo Chevalier
sr: Марко Костић (Marko Kostić)
sv-SE: Luna Jernberg
tr: Grk
zh-CN: Ariel
zh-CN: Olvcpr423
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@canova@fatadel