Uh oh!
There was an error while loading. Please reload this page.
FCE-3728 / add recordings methods - #91
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds recording lifecycle support to the SDK, including REST operations, public models, notifications, and error handling.
Changes:
- Adds create, list, get, stop, and delete recording methods.
- Exposes recording models and status notifications.
- Improves HTTP error handling and adds recording API tests.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
tests/test_recording_api.py | Tests recording operations and errors. |
fishjam/recording/__init__.py | Exports recording models. |
fishjam/events/allowed_notifications.py | Allows recording notifications. |
fishjam/events/_protos/fishjam/__init__.py | Adds recording notification protobuf types. |
fishjam/events/__init__.py | Exports recording events. |
fishjam/errors.py | Adds quota and fallback error handling. |
fishjam/api/_fishjam_client.py | Implements recording operations. |
fishjam/api/_client.py | Handles undocumented HTTP errors. |
fishjam/_openapi_client/models/recording_status.py | Adds the finished status. |
fishjam/_openapi_client/api/recordings/stop_recording.py | Adds the generated stop endpoint. |
fishjam/_openapi_client/api/recordings/delete_recording.py | Handles conflicts and updates endpoint docs. |
fishjam/__init__.py | Exposes recording APIs publicly. |
Files not reviewed (1)
- fishjam/events/_protos/fishjam/init.py: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Address PR review comments: cover get_recording/stop_recording 200 responses and the recording status notification webhook round-trip. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Karolk99
approved these changes
Aug 14, 2026
Bump protos to 6d469f9 (recording status enum gains STATUS_UNSPECIFIED) and raise StaleSdkError when a recording status notification carries UNSPECIFIED or an unknown wire value — both mean this SDK is likely too old to parse the statuses the server sends. Mirrors the js-server-sdk change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds recording methods and notification types.
Motivation and Context
Allows to use recordings with this SDK.
Documentation impact
Types of changes
not work as expected)