') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); fix: refresh 2.x scaffolding after the beta and RC releases by imorland · Pull Request #54 · flarum/cli · GitHub
Skip to content

fix: refresh 2.x scaffolding after the beta and RC releases - #54

Merged
imorland merged 1 commit into
3.xfrom
im/refresh-2x-scaffolding
Aug 1, 2026
Merged

fix: refresh 2.x scaffolding after the beta and RC releases#54
imorland merged 1 commit into
3.xfrom
im/refresh-2x-scaffolding

Conversation

@imorland

@imorlandimorland commented Aug 1, 2026

Copy link
Copy Markdown
Member

The last release was v3.0.11 in April 2025, before the remaining betas and every RC. Four things have drifted since; the first one stops a generated extension working at all.

Generated extensions can't run static analysis

boilerplate/skeleton/extension/phpstan.neon sets checkMissingIterableValueType: false, a parameter removed in PHPStan 2. flarum/phpstan ^2.0 installs PHPStan ^2.1, so composer analyse:phpstan on a freshly scaffolded extension fails before analysing anything:

Invalid configuration:
Unexpected item 'parameters › checkMissingIterableValueType'.

Verified by running PHPStan 2 against that exact config in a real 2.x extension — and verified fixed the same way (13 files analysed, no configuration error).

Skeleton asks for the wrong jest config

@flarum/jest-config: ^1.0.1, where core 2.x uses ^2.0.0. v1 also depends on flarum-webpack-config ^2.0.1, which contradicts the ^3.0.0 the skeleton specifies in the same file.

Worth noting: the upgrade command already sets ^2.0.0, so an extension upgraded to 2.x got this right while a newly created one did not.

The upgrade command still writes beta constraints

flarum/core, flarum/testing and flarum/phpstan were pinned to ^2.0.0-beta — correct when written, but it now leaves every upgraded extension asking for a beta of a line that has reached RC.

These become ^2.0.0. Since 2.0 is still prerelease, the command now also sets minimum-stability: "beta" and prefer-stable: true on the extension's composer.json, so the constraint resolves while preferring stable releases for everything that has one.

PHP floor

The upgrade command rewrote require.php to ^8.2. Core 2.x requires ^8.3.

Verification

yarn test — 22 suites, 176 tests, Prettier clean; tsc --noEmit clean. The PHPStan change was checked against a real extension's installed PHPStan 2 rather than by reading.

The skeleton's minimum-stability stays dev — deliberate, and unchanged here.

@imorland
fix: refresh 2.x scaffolding after the beta and RC releases
6996270
Generated extensions could not run static analysis at all. The skeleton
still set checkMissingIterableValueType, which PHPStan 2 removed, so
'composer analyse:phpstan' died with 'Invalid configuration' on a
freshly created extension — flarum/phpstan ^2.0 installs PHPStan ^2.1.
The skeleton also asked for @flarum/jest-config ^1.0.1. Core 2.x uses
^2.0.0, and v1 pulls in flarum-webpack-config ^2.0.1 against the ^3.0.0
the skeleton specifies. The upgrade command already got this right,
so an extension upgraded to 2.x was correct while a new one was not.
The upgrade command pinned flarum/core, flarum/testing and
flarum/phpstan to ^2.0.0-beta, written when 2.0 was in beta and now
leaving upgraded extensions asking for a beta of a line that has since
reached RC. Those become ^2.0.0, with minimum-stability beta and
prefer-stable so the constraint still resolves while 2.0 is prerelease.
Its PHP floor also said ^8.2; core 2.x requires ^8.3.
@imorland
imorland merged commit 2dccee5 into 3.xAug 1, 2026
3 checks passed
@imorland
imorland deleted the im/refresh-2x-scaffolding branch August 1, 2026 00:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@imorland