Uh oh!
There was an error while loading. Please reload this page.
Bundle new UUID - #112
Conversation
Uh oh!
There was an error while loading. Please reload this page.
| return buf | ||
| } | ||
| func (b *MevBundle) ComputeUUID() uuid.UUID { |
There was a problem hiding this comment.
suggestion (non-blocking)
We should probably eventually use a sync.Once pattern to initialize the UUID once since we don't mutate bundles after initialization
There was a problem hiding this comment.
Yeah, I thought in a little bit different direction, I believe we'll eventually move to propagating this uuid as a field of bundle structure, but it'd be better be done once we have some module with shared models. But I anyway understand your concern, I hope we'll address it in future
Wazzymandias
commented
Sep 22, 2023
looks great! Could you update your PR description with output successfully showing bundles inserted into database with the new schema and UUID? Otherwise lgtm, good stuff |
TymKh
commented
Sep 24, 2023
Done |
* fix issue with geth not shutting down (flashbots#97) * Add eth_callBundle rpc method (flashbots#14) * flashbots: add eth_estimateGasBundle (flashbots#102) * feat(ethash): flashbots_getWork RPC with profit (flashbots#106) * Calculate megabundle as soon as it's received (flashbots#112) * Add v0.5 specification link (flashbots#118)
* fix issue with geth not shutting down (flashbots#97) * Add eth_callBundle rpc method (flashbots#14) * flashbots: add eth_estimateGasBundle (flashbots#102) * feat(ethash): flashbots_getWork RPC with profit (flashbots#106) * Calculate megabundle as soon as it's received (flashbots#112) * Add v0.5 specification link (flashbots#118)
📝 Summary
Groundwork for using unique deterministic ID for bundles
Example of new inserted bundle from goerli (json extracted from db, stripped from irrelevant data):
📚 References
CONTRIBUTING.md