Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Oct 25, 2024. It is now read-only.
Refactor miner tests and how bundles are ordered to allow easier extensibility - #32
Merged
Conversation
Ruteri
commented
Dec 23, 2022
CollaboratorAuthor
Cc @lmittmann |
Ruteriforce-pushed
the
pr-27-rebase
branch
2 times, most recently
from
December 23, 2022 15:45
1dfc9f6 to
d7cecadComparedvush
approved these changes
Dec 26, 2022
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| func (s TxByNonce) Less(i, j int) bool { return s[i].Nonce() < s[j].Nonce() } | ||
| func (s TxByNonce) Swap(i, j int) { s[i], s[j] = s[j], s[i] } | ||
| type _Order interface { |
Contributor
There was a problem hiding this comment.
why aren't bundles and related types in a separate file like builder.go?
CollaboratorAuthor
There was a problem hiding this comment.
This particular type is used internally by TxWithMinerFee so this is I think the more fitting place
avalonche
approved these changes
Dec 28, 2022
avalonche pushed a commit
that referenced
this pull request
Feb 7, 2023
avalonche pushed a commit
that referenced
this pull request
Mar 9, 2023
avalonche pushed a commit
that referenced
this pull request
Mar 15, 2023
avalonche pushed a commit
that referenced
this pull request
Mar 17, 2023
avalonche pushed a commit
that referenced
this pull request
Mar 22, 2023
avalonche pushed a commit
that referenced
this pull request
Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Moves the
BuilderPayloadAttributesstructure to common libraryRefactors miner test setup
Refactors builder setup and how env header is prepared
New channel unit testing utility
Adds two new kinds of algo tests with proper contract calls in preparation of new kinds of testing we want to do in the near future
Adds simulation backend for use in miner algo unit tests
📚 References
Rebased #27
CONTRIBUTING.md