Uh oh!
There was an error while loading. Please reload this page.
chore: bump go-flashduty to v0.14.1 and regenerate - #162
Merged
Conversation
v0.14.1 models /template/update's optional fields as nullable, so the generated `template update` flags now carry the partial-update contract in their help text: every channel says "Omit to keep the current content; send an empty string to clear it", and --team-id says omitting keeps the template's current team. That wording reaches the skill card's generated fence too, so the card and the binary now say the same thing. More importantly the SDK change is what makes clearing possible at all. The CLI binds its flag map into TemplateUpdateRequest before sending, so while those fields were value types with omitempty, `--dingtalk-app ''` was dropped by the encoder and never reached the wire. With pointers it does. 45 files change here but only skills/flashduty/reference/template.md is caused by the bump. The other 42 are pre-existing drift: the committed generated output did not match what cligen + skilldoc produce from the SDK main already pinned. Verified by regenerating on an untouched checkout of main, which produces those same 42 files. This repo has no generate-drift CI job to catch that, unlike go-flashduty. make check-cards reports `skilldoc: cards OK`; build, vet and tests are green.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
go-flashdutyv0.14.1 models/template/update's optional fields as nullable. That matters to this repo for two reasons.It is what makes clearing a channel work. The generated commands assemble a flag map and bind it into
TemplateUpdateRequestbefore sending. While those fields were value types withomitempty,--dingtalk-app ''was dropped by the encoder and never reached the wire — a clear was a silent no-op. With pointers it reaches the server.It puts the contract in the help text. Every channel flag on
template updatenow reads "Omit to keep the current content; send an empty string to clear it", and--team-idsays omitting keeps the template's current team. That wording flows into the skill card's generated fence, so the card and the binary agree.About the diff size
45 files, but only
skills/flashduty/reference/template.mdis caused by this bump.The other 42 are pre-existing drift — the committed generated output did not match what
cligen+skilldoc genproduce from the SDKmainalready pinned (v0.14.0). Verified by regenerating on an untouched checkout ofmain: it produces those same 42 files. They are swept in here because the committed state should equal generator output.Worth noting separately: this repo has no generate-drift CI job, which is why that went unnoticed.
go-flashdutyhas one and it catches exactly this.Checks
make check-cards→skilldoc: cards OK.go build ./...,go vet ./...,go test ./...all green.