Uh oh!
There was an error while loading. Please reload this page.
chore(sdk): bump go-flashduty, regenerate CLI for the monit sparse-field contract - #92
Merged
Merged
Conversation
Picks up go-flashduty 4d5816a (PR #31), which regenerates the SDK from the corrected monit OpenAPI spec (flashduty-docs #190). monit contract — the reason for this bump: monit-webapi d0d1ef4 turned /monit/tools/invoke and /monit/tools/catalog into sparse-field responses (omit instead of null) and flattened the single-tool result envelope. The CLI's generated response-help still documented the old nested/nullable shape, telling callers to expect "data": null and "error": null placeholders that the server no longer sends. Now aligned: data/summary/truncated/tool_version/error/target/ target_kinds/next_cursor/output_shape are all documented as present-only. Carried along — unrelated SDK work already merged upstream that this regen necessarily picks up (the dep bump and the regen must be one commit or CI's cligen drift check fails): New commands flashduty licenses ... flashduty session-replay ... Breaking flag changes a2a-agent create/update: --description removed, --instructions now required (the API deprecated description in favour of instructions) session list/info: entry_kind enum value scheduled -> automation New flags a2a-agent: --allow-insecure-oauth-http, --allow-insecure-tls-skip-verify, --environment-id, --environment-kind, --query a2a-agent list: --scope enum all|personal|team -> all|account|team automation create: --cron-expr no longer marked required Cards regenerated via `make gen-cards`; monit-agent.md / monit.md are unchanged here because PR #91 already landed those fixes. make check green: gofmt+gci clean, golangci-lint 0 issues, go test -race all packages ok, build ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third link in the monit contract chain: flashduty-docs #190 → go-flashduty #31 (merged) → this PR → runner bundle → sandbox.
Why
monit-webapi
d0d1ef4changed/monit/tools/invokeand/monit/tools/catalogto sparse-field responses — absent means empty, nonullplaceholders — and flattened the single-tool result (no nesteddata.data). The CLI's generated response-help still described the old shape, soflashduty diagnostics tools-invoke --helptold callers to expect"data": null/"error": null/"tool_version": ""fields the server no longer sends.What
go get github.com/flashcatcloud/go-flashduty@4d5816a+go run ./internal/cmd/cligen+make gen-cards, in one commit —zz_generated_*.goare generated from the linked SDK's embeddedopenapi.en.json, so a split commit fails CI's cligen drift check.monit-facing result:
data/summary/truncated/tool_version/ per-toolerror/target/error.target_kinds/next_cursor/output_shapeare now all documented as present-only.Carried along (honest disclosure)
The regen also picks up unrelated SDK work already merged upstream. This is not optional — the regen is whole-tree.
New commands
flashduty licenses …flashduty session-replay …Breaking
a2a-agent create/update:--descriptionremoved,--instructionsnow required (API deprecateddescriptionin favour ofinstructions)session list/info:entry_kindenumscheduled→automationAdditive
a2a-agent:--allow-insecure-oauth-http,--allow-insecure-tls-skip-verify,--environment-id,--environment-kind,--querya2a-agent list:--scopeenumall|personal|team→all|account|teamautomation create:--cron-exprno longer marked requiredskills/flashduty/reference/monit-agent.mdandmonit.mdare unchanged here — PR #91 already landed those card fixes andmake gen-cardsreproduces them byte-for-byte.Verification
make checkgreen locally: gofmt+gci clean,golangci-lint0 issues,go test -race ./...all packages ok, build ok. CLI JSON and toon output were previously verified key-for-key identical to the live webapi wire on both success and error paths against dev (localhost:11480, targetdevbox.107.local).Follow-up
Merging this unblocks tag
v1.3.27→ flashduty-runnerFDUTY_VERSIONbump + checksums → runner release → sandbox image rebuild/repoint → prod overlay.