Conversation
|
I'm not too sure how I want to handle Giphy content, since it's kind of third party content that I cannot control really. Of course it's Twitch's job to policy what is allowed to be sent, but Google Play can be very strict in that regard and other Chat Apps got banned for way less. Might introduce this via a developer setting? Not sure. |
|
I had not considered how Google Play might handle it. I assume it does not make any difference from their perspective that the official Twitch app displays the exact same content? I will add some explanatory comments. No API needed, twitch provides the gif url and its position in the message through the gifs tag and you can load that url directly. The only reason to manipulate the url is that you can request a different size or format from giphy. For example replacing |
# Conflicts: # app/src/main/kotlin/com/flxrs/dankchat/ui/chat/messages/PrivMessage.kt
f60a167 to
46a5200
Compare
|
Ah, I hadn't looked at how Twitch provides these gifs. If they are coming through message tags I guess we are fine? I'll test this out this weekend or so. Thanks for all the great PRs btw, coming back from vacation to this was a surprise |
Adds support for twitch gif messages