Decouple the app version from the pinned ezvpn core - #14
Merged
Merged
Conversation
ezvpn.versionName/versionCode are now the app's own version: bump-jnilibs.sh runs in core-key mode and only rewrites the release pin. The pinned release (minus "v") is exposed as BuildConfig.EZVPN_CORE_VERSION so the footer reads "ezvpn 0.0.44 · core 0.0.44". The app version stays at 0.0.44 (code 5) as its starting point. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016bFY7oe5SzmhaKxy3TTo3y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ezvpn.versionName/ezvpn.versionCodeare now the app's own version;scripts/bump-jnilibs.shruns incore-keymode (new option in the shared devtools script) and only rewrites the release pin.app/build.gradle.ktsexposes the pinned release asBuildConfig.EZVPN_CORE_VERSION; the footer readsezvpn 0.0.44 · core 0.0.44.Requires the devtools commit that adds
BUMP_VERSION_MODEtoandroid/bump-jnilibs.sh(pushed to devtools main).Test plan
./gradlew :app:assembleDebug :app:testDebugUnitTestlocally; generated BuildConfig hasEZVPN_CORE_VERSION = "0.0.44"scripts/bump-jnilibs.sh v0.0.44is a no-op diff🤖 Generated with Claude Code
https://claude.ai/code/session_016bFY7oe5SzmhaKxy3TTo3y