Make the README and device scripts device-agnostic - #8
Merged
Merged
Conversation
Drop the hard-coded LAN serial of one development VM from the README and the scripts: run-device.sh targets ADB_SERIAL, else EMULATOR_SERIAL, else the single attached device, and install-release-apk.sh only refuses the development emulator when EMULATOR_SERIAL is set. Document how to see and drive a device from a terminal (screencap, scrcpy + scrot, adb input, uiautomator dump, the Compose/Gboard quirks) in place of the old emulator-specific scrcpy note. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BBaYWbDVczX9BdFXTkLppM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the hard-coded LAN serial of one development VM from the README and the scripts.
run-device.shtargetsADB_SERIAL, elseEMULATOR_SERIAL, else the single attached device;install-release-apk.shonly refuses the development emulator whenEMULATOR_SERIALis set. Adds a README section on seeing and driving a device from a terminal (screencap, scrcpy + scrot, adb input, uiautomator dump, Compose/Gboard quirks) in place of the old emulator-specific scrcpy note.Tested: several-devices error path, bogus/emulator guards, and the happy path (
EMULATOR_SERIAL=<vm> scripts/run-device.sh --pinned --no-log) on the development VM.🤖 Generated with Claude Code
https://claude.ai/code/session_01BBaYWbDVczX9BdFXTkLppM