Close the iroh endpoint gracefully on mobile stop and release 0.0.42 - #56
Merged
Merged
Conversation
EzvpnHandle::stop only aborted the run task and dropped the runtime, which sends nothing on the wire: the server kept the client's address lease until the 30 s QUIC idle timeout. Keep a clone of the session's endpoint in the handle and close it (CONNECTION_CLOSE) on a short-lived teardown thread that owns the runtime, bounded by a 3 s timeout built inside the runtime context. The server now logs the disconnect immediately. Also note in the build script and Android design doc that development and testing happen on the arm64 Android VM, with the physical device reserved for the signed release APK. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QedowxAkQAV7HoeJu8ZYZC
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QedowxAkQAV7HoeJu8ZYZC
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EzvpnHandle::stop(mobile FFI) now closes the iroh endpoint gracefully on a short-lived teardown thread (3 s cap, timeout built inside the runtime context) instead of just dropping the runtime. Previously nothing went on the wire, so the server only freed the client's address lease at the 30 s QUIC idle timeout; now it logs the disconnect immediately.build-android.shanddocs/Android-App.mdthat development/testing happens on the arm64 Android VM and the physical device only receives the signed release APK.Test plan
cargo clippy,cargo ndk -t arm64-v8a --platform 29 clippy --lib -- -D warnings,cargo testclean🤖 Generated with Claude Code
https://claude.ai/code/session_01QedowxAkQAV7HoeJu8ZYZC