Rebase the iroh backpressure fork onto v1.1.0; 0.0.44 - #58
Merged
Merged
Conversation
Upstream iroh v1.1.0 still drops a transmit when the transport returns Pending (transports.rs is byte-identical to v1.0.3 there), so the fork is still required. The single fork commit is cherry-picked onto v1.1.0 as branch ezvpn-send-backpressure-1.1.0. noq-proto moves to 1.2.0 to match iroh 1.1.0 so the lockfile carries one copy of the noq crates. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016bFY7oe5SzmhaKxy3TTo3y
Rust 1.98's clippy flags chunks_exact with a constant size (chunks_exact_to_as_chunks); CI on main was red on this since the "update" commit. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016bFY7oe5SzmhaKxy3TTo3y
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016bFY7oe5SzmhaKxy3TTo3y
andrewchen5678
force-pushed
the
iroh-1.1.0
branch
from
September 1, 2026 22:29
7f0ed72 to
a39e3f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Poll::Pendingfrom the transport intoPoll::Ready(Ok(()))inUdpSender::poll_send, silently dropping the transmit (iroh/src/socket/transports.rsis byte-identical between v1.0.3 and v1.1.0, and the same code is on upstream main). The fork is therefore still required.andrewtheguy/irohbranchezvpn-send-backpressure-1.1.0(dfaa3ba8); it applied cleanly.noq-protomoves to 1.2.0 to match iroh 1.1.0, so the lockfile carries one copy of the noq crates.chunks_exact_to_as_chunkslint from Rust 1.98's clippy inoffload.rsthat had CI on main red since the "update" commit.Test plan
cargo clippy --workspace --all-targets -- -D warningscargo test --workspacecargo ndk -t arm64-v8a --platform 29 clippy --lib -- -D warnings🤖 Generated with Claude Code
https://claude.ai/code/session_016bFY7oe5SzmhaKxy3TTo3y