Revert "Revert "Revert "Format code base with Prettier and auto check PRs"""

[tracygardner]

Reverts #421

Summary by CodeRabbit

• New Features

  • Enhanced event block UI with inline/toggle button support for better workflow organization
  • Improved camera positioning and vertical constraint handling for character-relative views

• Bug Fixes

  • Fixed UI control cleanup in input reinitialization
  • Improved event name validation with user feedback

• Chores

  • Removed Prettier workflow and configuration from development pipeline
  • Updated documentation and code formatting standards

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8b6b84af-65be-495d-b3ad-aa9e0c02f3b0

📥 Commits

Reviewing files that changed from the base of the PR and between 193ef89 and 8272115.

⛔ Files ignored due to path filters (5)

• images/data.svg is excluded by !**/*.svg
• images/events.svg is excluded by !**/*.svg
• images/functions.svg is excluded by !**/*.svg
• images/scene.svg is excluded by !**/*.svg
• package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (133)

• .gitattributes
• .github/workflows/prettier.yml
• .github/workflows/run-mocha-tests.yml
• .github/workflows/static.yml
• .prettierignore
• API.md
• CONTRIBUTING.md
• README.md
• README_TOOLS.md
• TRANSLATION.md
• accessibility/accessibility.js
• api/animate.js
• api/camera.js
• api/csg.js
• api/effects.js
• api/events.js
• api/material.js
• api/math.js
• api/mesh.js
• api/models.js
• api/scene.js
• api/sensing.js
• api/shapes.js
• api/sound.js
• api/transform.js
• api/ui.js
• api/xr.js
• blocks/animate.js
• blocks/base.js
• blocks/blocks.js
• blocks/camera.js
• blocks/colour.js
• blocks/combine.js
• blocks/condition.js
• blocks/connect.js
• blocks/control.js
• blocks/effects.js
• blocks/events.js
• blocks/materials.js
• blocks/models.js
• blocks/physics.js
• blocks/scene.js
• blocks/sensing.js
• blocks/shapes.js
• blocks/sound.js
• blocks/transform.js
• blocks/xr.js
• config.js
• cubeart.html
• dev-docs/ADDING_API_DOCS_SUMMARY.md
• dev-docs/API_QUALITY_TOOLS.md
• dev-docs/API_RECONCILIATION_PLAN.md
• dev-docs/GETTING_STARTED.md
• dev-docs/IMPLEMENTATION_STATUS.md
• dev-docs/dev-docs.md
• docs/docs.md
• docs/models.md
• eslint.config.mjs
• flock.js
• fonts/FreeSans_Bold.json
• funding.json
• generators/generators.js
• index.html
• locale/de.js
• locale/en.js
• locale/es.js
• locale/fr.js
• locale/it.js
• locale/pl.js
• locale/pt.js
• locale/sv.js
• main/blockhandling.js
• main/blocklyinit.js
• main/customCommentIcon.js
• main/debug.js
• main/execution.js
• main/export.js
• main/files.js
• main/input.js
• main/loading.js
• main/main.js
• main/themes.js
• main/view.js
• package.json
• playwright.config.js
• replit.md
• scripts/README.md
• scripts/api-coverage-report.mjs
• scripts/check-link-security.mjs
• scripts/csp-smoke.mjs
• scripts/run-api-tests.mjs
• scripts/utils/extract-api-methods.mjs
• scripts/utils/parse-api-md.mjs
• scripts/utils/parse-jsdoc.mjs
• scripts/utils/test-analyzer.mjs
• style.css
• style/blockly.css
• tests/animate.test.js
• tests/babylon.test.js
• tests/blocks.test.js
• tests/boxes.test.js
• tests/characterAnimations.test.js
• tests/concurrency.test.js
• tests/effects.test.js
• tests/getProperty.test.js
• tests/glide.test.js
• tests/glideToObject.test.js
• tests/materials.test.js
• tests/objects.test.js
• tests/physics.test.js
• tests/playwright/blocks.spec.js
• tests/playwright/visual.spec.js
• tests/sound-api-investigation.test.js
• tests/sound-integration.test.js
• tests/sound-replacement-diagnostic.test.js
• tests/sound-verification.test.js
• tests/sound.test.js
• tests/transform.rotate.test.js
• tests/transform.scale.test.js
• tests/transform.translate.test.js
• tests/uitextbutton.test.js
• tests/utils/audioTestUtils.js
• toolbox.js
• tutorial.html
• tutorial.js
• ui/addmenu.js
• ui/blocklyshadowutil.js
• ui/blocklyutil.js
• ui/blockmesh.js
• ui/colourpicker.css
• ui/colourpicker.js
• ui/gizmos.js
• vite.config.mjs

---

📝 Walkthrough

Walkthrough

This pull request removes Prettier-related configuration files and workflows, then applies extensive code formatting and refactoring across the API and blocks modules. Key functional updates include camera control improvements, event block inline behavior, model block dynamic colors, and animation block handler registration.

Changes

Cohort / File(s)	Summary
Prettier configuration removal .gitattributes, .github/workflows/prettier.yml, .prettierignore	Removes Prettier-related configurations: LF line ending rule, prettier workflow, and ignore patterns allowing formatter to process previously ignored files.
GitHub workflow formatting .github/workflows/run-mocha-tests.yml, .github/workflows/static.yml	Minor formatting adjustments to workflow syntax and cache configuration without functional changes.
Documentation cleanup API.md, CONTRIBUTING.md, README.md, README_TOOLS.md, TRANSLATION.md, dev-docs/*	Documentation reformatting and content removal (blank lines, example code cleanup); minor JSDoc path correction in README_TOOLS.md from escaped to unescaped asterisk.
API camera system refactoring api/camera.js	Significant refactoring: attachCamera() consolidated to single flow, ensureVerticalConstraint() rewritten with 6DoF constraint and velocity limiting; added internal helpers _normalizeKeyCode(), _applyCameraBinding(), _reapplyCameraBindings(); removed public getCamera() method.
API UI improvements api/ui.js	Added disposal of submit control in UIInput on reinitialization; formatting adjustments to ternaries and property assignments.
API formatting standardization api/animate.js, api/effects.js, api/material.js, api/math.js, api/mesh.js, api/models.js, api/scene.js, api/sensing.js, api/shapes.js, api/sound.js, api/transform.js, api/xr.js, accessibility/accessibility.js	Primarily formatting and code style changes: single-line consolidation of multi-line calls, quote normalization, indentation alignment, trailing comma removal; no behavioral changes.
Blocks animate handler blocks/animate.js	Added ANIMATION_GROUP handler registration for animation block creation via handleBlockCreateEvent(); extensive formatting adjustments to block definitions.
Blocks event system expansion blocks/events.js	Major refactor: added inline toggle behavior to multiple event blocks (start, forever, when_clicked, on_collision, when_key_event, when_action_event); new validation function getEventNameValidationError() for event name checking; enhanced mutation handlers and updateShape logic; new broadcast_event and on_event blocks with dedicated init/onchange.
Blocks condition restructuring blocks/condition.js	Refactored controls_if block indirection: captured original init and applied new help URL/style/tooltip via override; consolidated custom controls_if_custom block definition.
Blocks model color dynamics blocks/models.js	Enhanced load_object/load_multi_object with dynamic COLOR field updates based on MODEL selection; added updateColorField/updateColorsField mechanisms; improved event handling flow with targeted field propagation.
Blocks imports reorganization blocks/camera.js, blocks/physics.js, blocks/transform.js, blocks/xr.js	Consolidated and repositioned imports (getHelpUrlFor, translation helpers); no functional impact, purely structural organization.
Blocks formatting standardization blocks/base.js, blocks/blocks.js, blocks/colour.js, blocks/combine.js, blocks/connect.js, blocks/control.js, blocks/effects.js, blocks/materials.js, blocks/scene.js, blocks/sensing.js, blocks/shapes.js, blocks/sound.js, blocks/transform.js, blocks/xr.js	Extensive indentation, whitespace, and quote normalization across block definitions; no semantic or behavioral changes.
Configuration formatting config.js	Re-indentation of arrays and object literals (audioNames, characterNames, etc.); no functional changes to exports or values.
HTML structure and formatting cubeart.html	Formatting and indentation adjustments; closes canvas with </div> instead of </canvas> (potential structural issue).

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Possibly related PRs

• Format code base with Prettier and auto check PRs #414: Directly related as this PR undoes Prettier configuration changes from #414, removing the .gitattributes LF rule, deleting the Prettier workflow, and modifying .prettierignore to reverse ignore-list restrictions.

Poem

🐰 Hop through the code, format it right,
Prettier's gone, blocks shine bright!
Events now toggle, models dance free,
Camera flows smooth—refactored spree! ✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch revert-421-revert-418-revert-414-prettier-v3

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}