Uh oh!
There was an error while loading. Please reload this page.
Handle mesh creation when blocks are moved to enabled chains - #580
Conversation
When an object block is connected to an enabled top block, the event is BLOCK_MOVE not BLOCK_CREATE, so isImmediateEnabledCreate was never true and createMeshOnCanvas was never called. Add isConnectedMove to cover this case. https://claude.ai/code/session_018FzuL691PTMx5puGLJd4i1
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
Deploying flockxr with |
| Latest commit: | fd0f517 |
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f8252009.flockxr.pages.dev |
| Branch Preview URL: | https://claude-fix-object-visibility.flockxr.pages.dev |
Uh oh!
There was an error while loading. Please reload this page.
Summary
This change extends the mesh creation logic to handle block move events in addition to block creation events. Previously, meshes were only created when a block was first created and connected to an enabled chain. Now, meshes are also created when a block is moved into an enabled chain.
Key Changes
isConnectedMovecondition to detect when a block is moved (BLOCK_MOVEevent) to an enabled chain with no existing meshesisConnectedMovein addition to existingisEnabledEventandisImmediateEnabledCreateconditionsImplementation Details
The new logic mirrors the existing
isImmediateEnabledCreatepattern, checking for:BLOCK_MOVEchange event typeThis ensures that when users move blocks into an enabled chain, the corresponding 3D mesh is created immediately, providing consistent behavior whether blocks are created in-place or moved into position.
https://claude.ai/code/session_018FzuL691PTMx5puGLJd4i1
Summary by CodeRabbit
Release Notes