Skip to content

Refactor mesh selection into shared handler and improve camera focus selection behavior#604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tracygardner merged 2 commits into from
May 4, 2026
Merged

Refactor mesh selection into shared handler and improve camera focus selection behavior #604

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3c15cf
Make F-key focus reuse select gizmo mesh selection
tracygardner May 4, 2026
300b9d7
Ensure F-focus selection enables mesh bounding box
tracygardner May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 32 additions & 27 deletions ui/gizmos.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -380,6 +380,7 @@ function focusCameraOnMesh() {
if (mesh && mesh.name === "ground") mesh = null;
}
if (!mesh) return;
applyMeshSelection(mesh);

mesh.computeWorldMatrix(true);
const { min, max } = mesh.getHierarchyBoundingVectors(true);
Expand All@@ -401,6 +402,36 @@ function focusCameraOnMesh() {
camera.setTarget(newTarget);
}

function applyMeshSelection(pickedMesh, pickedPoint) {
if (pickedMesh && pickedMesh.name !== "ground") {
if (pickedMesh.parent) {
pickedMesh = getRootMesh(pickedMesh.parent);
pickedMesh.visibility = 0.001;
}
const block = meshMap[pickedMesh?.metadata?.blockKey];
highlightBlockById(Blockly.getMainWorkspace(), block);
gizmoManager.attachToMesh(pickedMesh);
enableBoundingBox(pickedMesh);
return;
}

if (pickedMesh && pickedMesh.name === "ground") {
const roundedPosition = roundVectorToFixed(pickedPoint, 2);
flock.printText({
text: translate("position_readout").replace(
"{position}",
String(roundedPosition),
),
duration: 30,
color: "black",
});
}
if (gizmoManager.attachedMesh) {
resetChildMeshesOfAttachedMesh();
gizmoManager.attachToMesh(null);
}
Comment on lines +429 to +432

@coderabbitaicoderabbitaiBotMay 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Composite mesh root visibility is not restored on deselect — visual regression

When a composite (e.g. glTF) mesh is selected, applyMeshSelection sets its root's visibility to 0.001 (line 409) so the bounding box renders. On deselect, the deselect path (lines 429-432) calls resetChildMeshesOfAttachedMesh() and gizmoManager.attachToMesh(null). The patched attachToMesh internally calls resetAttachedMesh → hideBoundingBox, but neither path calls resetBoundingBoxVisibilityIfManuallyChanged, so the root mesh's visibility stays at 0.001 — the model remains fractionally visible after being "deselected".

turnOffAllGizmos handles this correctly (line 1920), but it is not in the click-to-deselect flow.

🐛 Proposed fix
 if (gizmoManager.attachedMesh) {
+ resetBoundingBoxVisibilityIfManuallyChanged(gizmoManager.attachedMesh);
resetChildMeshesOfAttachedMesh();
gizmoManager.attachToMesh(null);
}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@ui/gizmos.js` around lines 429 - 432, The deselect path leaves a composite
root's visibility at 0.001 because resetBoundingBoxVisibilityIfManuallyChanged
isn't called; update the click-to-deselect flow so after
resetChildMeshesOfAttachedMesh() (and before or after
gizmoManager.attachToMesh(null)) you explicitly call
resetBoundingBoxVisibilityIfManuallyChanged for the previously attached mesh (or
invoke the same sequence turnOffAllGizmos uses) so the root mesh visibility is
restored; reference functions: applyMeshSelection,
resetChildMeshesOfAttachedMesh, resetBoundingBoxVisibilityIfManuallyChanged,
resetAttachedMesh, hideBoundingBox, gizmoManager.attachToMesh, and
turnOffAllGizmos to locate where to insert the call.

}

function viewMeshWithCamera() {
let mesh = gizmoManager.attachedMesh;
if (mesh && mesh.name === "ground") mesh = null;
Expand DownExpand Up@@ -1774,34 +1805,8 @@ function handleSelectGizmo() {
duration: 30,
color: "black",
});
if (flock.meshDebug) console.log(pickedMesh.parent);
if (pickedMesh.parent) {
pickedMesh = getRootMesh(pickedMesh.parent);
if (flock.meshDebug) console.log(pickedMesh.visibility);
pickedMesh.visibility = 0.001;
if (flock.meshDebug) console.log(pickedMesh.visibility);
}
const block = meshMap[pickedMesh?.metadata?.blockKey];
highlightBlockById(Blockly.getMainWorkspace(), block);
gizmoManager.attachToMesh(pickedMesh);
pickedMesh.showBoundingBox = true;
} else {
if (pickedMesh && pickedMesh.name === "ground") {
const roundedPosition = roundVectorToFixed(pickedPoint, 2);
flock.printText({
text: translate("position_readout").replace(
"{position}",
String(roundedPosition),
),
duration: 30,
color: "black",
});
}
if (gizmoManager.attachedMesh) {
resetChildMeshesOfAttachedMesh();
gizmoManager.attachToMesh(null);
}
}
applyMeshSelection(pickedMesh, pickedPoint);
setTimeout(() => {
if (!getCanvasCircle()) document.body.style.cursor = "crosshair";
}, 0);
Expand Down
Loading