Skip to content

Update GitHub Actions workflows to use Node.js 24 and latest actions#656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tracygardner merged 1 commit into from
May 28, 2026
Merged

Update GitHub Actions workflows to use Node.js 24 and latest actions #656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/eslint.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,10 +7,10 @@ jobs:
eslint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@v5
- uses: actions/setup-node@v5
with:
node-version: 20
node-version: 24
- run: npm ci
- run: npx eslint .
continue-on-error: true # Remove to block PRs that fail the check
6 changes: 3 additions & 3 deletions .github/workflows/prettier.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@ jobs:
prettier:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@v5
- uses: actions/setup-node@v5
with:
node-version: 20
node-version: 24
- run: npx prettier --check .
continue-on-error: true # Remove to block PRs that fail the check
6 changes: 3 additions & 3 deletions .github/workflows/run-mocha-tests.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,15 +16,15 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-2022]
node-version: [20.x, 22.x, 24.x]
node-version: [24.x]

@coderabbitaicoderabbitaiBotMay 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | 🏗️ Heavy lift

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash# Description: Search for Node.js version requirements and support policy# Check package.json for engines fieldecho"=== Checking package.json engines field ==="
cat package.json | jq '.engines'# Search for Node.js version mentions in documentationecho -e "\n=== Searching for Node.js version documentation ==="
rg -i "node\.?js.*version|minimum.*node|supported.*node|requires.*node" README.md CONTRIBUTING.md docs/ -A 2 -B 2 2>/dev/null ||echo"No matches found in common docs"# Check for .nvmrc or .node-version filesecho -e "\n=== Checking for version constraint files ==="
fd -t f "^(\.nvmrc|\.node-version)$" -x cat {} \;

Repository: flipcomputing/flock

Length of output: 373

🏁 Script executed:

#!/bin/bashset -euo pipefail
echo"=== run-mocha-tests.yml matrix ==="
sed -n '1,120p' .github/workflows/run-mocha-tests.yml
echo -e "\n=== Search other CI workflows for node-version matrices ==="
fd -t f ".github/workflows"| wc -l >/dev/null 2>&1||true
rg -n "node-version:\s*\[" .github/workflows -S ||true
rg -n "matrix:.*node|strategy:|setup-node|actions/setup-node" .github/workflows -S ||trueecho -e "\n=== Search repo for 'minimum supported' wording ==="
rg -n "minimum supported Node\.js|single-target CI|treat Flock as an application|align test execution" -S .||trueecho -e "\n=== Search for explicit supported Node.js range beyond CONTRIBUTING ==="
rg -n "Node\.js \(version|Node\.js version|engines\"|\.nvmrc|\.node-version|supported.*Node" -S .||true

Repository: flipcomputing/flock

Length of output: 50769

Align CI Node.js matrix with the documented supported Node.js range

  • .github/workflows/run-mocha-tests.yml now tests only node-version: [24.x] (no Node 20/22).
  • Repo docs/scripts state Node.js “version 18 or higher” / “requires 18+”, so removing 20.x/22.x from CI reduces coverage for other supported Node majors.
  • If the intent is to raise the minimum supported Node.js to 24, update the documented support policy accordingly.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/run-mocha-tests.yml at line 19, The CI matrix in the
run-mocha-tests.yml workflow currently only tests node-version: [24.x]; update
the workflow's node-version matrix (the node-version entry in that workflow) to
include the supported Node majors (e.g., 18.x, 20.x, 22.x, 24.x) so CI covers
the documented “requires 18+” range, or if the project is intentionally raising
the minimum to 24, update the repository documentation/scripts that state
“version 18 or higher” to reflect the new minimum; ensure the change is applied
to the node-version matrix in the run-mocha-tests.yml workflow and any README or
scripts that declare the supported Node range.

# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
with:
ref: testable
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
uses: actions/setup-node@v5
with:
node-version: ${{ matrix.node-version }}
cache: "npm"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/static.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,7 @@ jobs:
url: ${{ steps.deploy_to_pages.outputs.github_pages_url }}
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v5
- name: Vite Github Pages Deployer
uses: skywarth/vite-github-pages-deployer@master
id: deploy_to_pages
Loading