Uh oh!
There was an error while loading. Please reload this page.
Fix selection and block highlight on workspace search - #725
Conversation
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughMobile workspace search gains ArrowUp/ArrowDown navigation, synchronizes its current result with Blockly selection, and updates desktop and low-vision match highlighting to use Blockly-selected paths. ChangesWorkspace search interaction
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant MobileSearchInput
participant workspaceSearch
participant BlocklyWorkspace
MobileSearchInput->>workspaceSearch: next() or previous()
workspaceSearch->>BlocklyWorkspace: select current block
BlocklyWorkspace->>workspaceSearch: selected block change
workspaceSearch->>workspaceSearch: update current result
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fixes a bug where clicking on a search result block would result in it turning fully yellow.
Sets the first result as the current selection to avoid weird cursor behaviour/confusing highlights.
AI usage
Claude Opus 5 used throughout. Plan created by me. Realised the previous implementation was not a good idea and changed it.
Summary by CodeRabbit
New Features
Bug Fixes