Uh oh!
There was an error while loading. Please reload this page.
Add tab for on-screen and gamepad controls - #731
Conversation
📝 WalkthroughWalkthroughAdds a docked Player Controls panel with translated on-screen and gamepad controls, focus-order and language-refresh integration, responsive styling, and updated shortcuts-panel icon markup. ChangesPlayer Controls Panel
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Browser
participant PlayerPanel
participant InfoPanel
participant PlayerPanelDOM
Browser->>PlayerPanel: init()
PlayerPanel->>InfoPanel: register('player', ...)
PlayerPanel->>PlayerPanelDOM: render grouped controls
PlayerPanelDOM-->>Browser: display player controls
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@accessibility/keyboardui.js`:
- Around line 1049-1088: Complete localization for the Player Controls entries:
in accessibility/keyboardui.js lines 1049-1088, replace hardcoded
controller-label strings with translation keys and resolve them before passing
values to formatKeys(). In locale/en.js lines 1347-1364, add the corresponding
controller-label keys to the active Spanish translation table alongside the
English definitions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 45d03e45-801c-4525-bd48-c6c9a6c086ee
📒 Files selected for processing (5)
accessibility/keyboardui.jslocale/en.jsmain/input.jsmain/translation.jsstyle.css
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Add new on-screen and gamepad controls button next to the keyboard controls button

AI usage
Claude Opus 5 and Haiku 4.5 both used on this. Several iterations were made because I wasn't happy with the format initially.
Summary by CodeRabbit
New Features
Accessibility
Style