Uh oh!
There was an error while loading. Please reload this page.
Add test for IPv6 functionality - #174
Conversation
c5cfd18 to
3e2c2e6Comparemcipperly
commented
Apr 21, 2021
Apologies for the spam, my git is rusty and I haven't built on another PR previously! Travis doesn't seem to support IPv6 (more info here and here ) so I did add a condition to skip in that case. Unfortunately this causes the IPv6 code to still not be covered through CI testing infrastructure - open to thoughts on how to address if this isn't workable. |
kenhys
commented
Apr 22, 2021
@mcipperly could you rebase tihis pull request? |
Signed-off-by: Matt Cipperly <mcipperly@fb.com>
Signed-off-by: Matt Cipperly <mcipperly@fb.com>
| else: | ||
| sock = socket.socket(socket.AF_INET6, | ||
| socket.SOCK_STREAM) | ||
| sock.settimeout(self.timeout) |
There was a problem hiding this comment.
Does it need to call _is_ipv4_host() in every _make_packet?
It may be able to reuse checked status.
Signed-off-by: Matt Cipperly <mcipperly@fb.com>
Signed-off-by: Matt Cipperly <mcipperly@fb.com>
mcipperly
commented
May 11, 2021
Updated to address the above re: not wanting to determine v4/v6 capability each time. Now:
Also added the |
I wrote a test for PR #138 which adds IPv6 support ( #137 )