Skip to content

Add formatted exception - #19

Open
EvaSDK wants to merge 1 commit into
fluent:masterfrom
EvaSDK:add-formatted-exception
Open

Add formatted exception#19
EvaSDK wants to merge 1 commit into
fluent:masterfrom
EvaSDK:add-formatted-exception

Conversation

@EvaSDK

Copy link
Copy Markdown
Contributor

This is a prototype for adding structured exception to a FluentRecordFormatter formatted message.
I am not sure yet if this is any useful and it is not exactly the cleanest way to add custom attributes to a record but this might be useful for someone.

@EvaSDK

Copy link
Copy Markdown
ContributorAuthor

This is based on MR #18 so the only interesting commit is the last one.

@EvaSDK
EvaSDKforce-pushed the add-formatted-exception branch from 9b37dee to dd0cf23CompareFebruary 3, 2015 14:51
@EvaSDK
EvaSDKforce-pushed the add-formatted-exception branch from dd0cf23 to 2cfa68cCompareMay 27, 2015 14:01
@EvaSDK
EvaSDKforce-pushed the add-formatted-exception branch from 2cfa68c to ac5a356CompareJune 17, 2015 08:41
@ngiallelis

Copy link
Copy Markdown
Contributor

Hi @EvaSDK! We can use logging.exc_text for formatted exception. As I mentioned in #38.

@EvaSDK

Copy link
Copy Markdown
ContributorAuthor

@ngiallelis, well the idea of using fluent is to keep structured log where possible, hence the use of traceback.extract_tb instead of pure text.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@EvaSDK@ngiallelis