Uh oh!
There was an error while loading. Please reload this page.
feat(chart): extension hook for extra pod-template annotations - #11
Closed
Ashley-Tung wants to merge 1 commit into
Closed
feat(chart): extension hook for extra pod-template annotations#11Ashley-Tung wants to merge 1 commit into
Ashley-Tung wants to merge 1 commit into
Conversation
Adds an overridable named template chalert.extraPodAnnotations rendered into the Deployment's pod-template annotations. Parent charts that wire rules in via existingRuleConfigMaps can override it to inject a checksum of their externally-rendered rule ConfigMaps, so rule changes roll the pod. The built-in checksum/rules only hashes this chart's own configmap.yaml, so external rule changes currently leave the Deployment spec unchanged and chalert (which loads rules once at startup) keeps evaluating stale rules. Default implementation is empty: no behavior change for existing consumers.
Ashley-Tung
commented
Aug 11, 2026
Author
@claude review |
Comment on lines
+90
to
+103
| Parent charts consuming chalert as a dependency may override this named | ||
| template (parent-chart definitions take precedence over subchart ones) to | ||
| inject computed annotations — most importantly a checksum of rule | ||
| ConfigMaps the parent renders itself and wires in via | ||
| `existingRuleConfigMaps`. The built-in `checksum/rules` annotation only | ||
| covers this chart's own configmap.yaml, so externally-rendered rule | ||
| changes do not roll the Deployment without such an override; chalert | ||
| loads rules once at startup and does not (yet) hot-reload them. | ||
| The template is rendered with the subchart's context: parent values are | ||
| NOT visible here except under `.Values.global`, so overrides must read | ||
| any data they need from global values. | ||
| Must emit zero or more `key: value` annotation lines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Today's PENG-38 rollout hit this live: the o11y-stack parent chart updated
tpu-chalert-rules(wired in viachalert.existingRuleConfigMaps), Argo synced the ConfigMap — and chalert kept evaluating the old rules, because the Deployment'schecksum/rulesannotation only hashes this chart's ownconfigmap.yaml. Externally-rendered rule ConfigMaps never enter the hash, so their changes don't roll the pod, and chalert loads rules once at startup.The obvious fix — hashing the parent's template from this chart — doesn't work: Helm subcharts render with their own scope, so
include-ing a parent template here silently evaluates it against chalert's values (guards go false, output is empty, hash is constant).Change
A tiny, backwards-compatible extension hook:
chalert.extraPodAnnotations, an empty named template rendered into the pod-template annotations. Parent charts override it (parent-chart template definitions take precedence over subchart ones) to inject their own computed checksums, reading any data they need from.Values.global(the only values visible across the chart boundary).Companion PR in fluidstackio/systems overrides the hook to hash the tpu rules content. Merge order: this first (needs a chart release consumers can pin), then the systems PR.
Notes
helm templateoutput is byte-identical).Test plan
helm lintclean;helm templateoutput identical to main when the hook is not overridden