Uh oh!
There was an error while loading. Please reload this page.
Add evals for add-dart-lint-validation-rule - #193
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive evaluation framework for AI agent skills within the dart_skills_lint package. It adds a new run-evals skill, defines per-skill and cross-skill evaluation rubrics (including a shared code quality rubric), and implements a structural consistency test for all evals.json files. Feedback on the newly added test highlights potential issues with brittle path resolution when running tests from different directories, as well as overly strict schema validation that could make future updates fragile.
Uh oh!
There was an error while loading. Please reload this page.
af04805 to
5fde5e7Compare9e73ef4 to
22dbac3Comparereidbaker
commented
Jul 23, 2026
/gemini-review |
Uh oh!
There was an error while loading. Please reload this page.
adding evals for the add-dart-lint-validation-rule skill.
This pr wasa blocked by #189
Evaluation Results
Evaluations were run to ensure that the updated
SKILL.mdinstructions correctly guide agents in creating custom validation rules, specifically focusing on correctly documenting CLI flags inREADME.mdwithout hallucinating prefixes.Eval 1:
RequireSpecificMetadataRuleRequireSpecificMetadataRulethat verifies metadata has arequired_versionfield.README.mdFlag:--[no-]require-specific-metadataRULES.md, added passing tests using an in-memorySkillContext, and perfectly adhered to the naming requirements for the flag inREADME.mdwithout hallucinating acheck-prefix.Eval 2:
FileExistenceRuleinfo.txtfile exists, using temp directories for testing.README.mdFlag:--[no-]file-existencefile-existenceflag pattern inREADME.md.Conclusion
The TDD-driven refinements to the
SKILL.mdfile (adding explicitCRITICAL FORMATTINGandCRITICAL NAMINGguidelines) successfully resolved the previous issues where agents hallucinated CLI flags. The subagents can now consistently author and document new lint rules cleanly.