Skip to content

[Homescreen codelab] Update dependencies - #2210

Merged
domesticmouse merged 1 commit into
flutter:mainfrom
wrbl606:homescreen_codelab_update_dependencies
Jun 16, 2024
Merged

[Homescreen codelab] Update dependencies#2210
domesticmouse merged 1 commit into
flutter:mainfrom
wrbl606:homescreen_codelab_update_dependencies

Conversation

@wrbl606

Copy link
Copy Markdown
Contributor
  • Update home_widget to 0.6.0, which adds support for Flutter 3.20+
  • Bump Kotlin version of the Android project as the fix suggests (see the message below)
┌─ Flutter Fix ──────────────────────────────────────────────────────────────────────────────────────┐
│ [!] Your project requires a newer version of the Kotlin Gradle plugin. │
│ Find the latest version on https://kotlinlang.org/docs/releases.html#release-details, then update │
│ /Users/marcinwroblewski/Documents/Projects/flutter-codelabs/homescreen_codelab/step_03/android/bui │
│ ld.gradle: │
│ ext.kotlin_version = '<latest-version>' │
└────────────────────────────────────────────────────────────────────────────────────────────────────┘

Pre-launch Checklist

  • I read the Effective Dart: Stylerecently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@wrbl606

Copy link
Copy Markdown
ContributorAuthor

Tests for Windows have failed, marking the checks as failed, but I don't think my changes caused that. It looks like the Flutter installation step has issues, can we circumvent the check and merge this to main or do I have to debug the Windows workflow?

@parlough

parlough commented Jun 16, 2024

Copy link
Copy Markdown
Member

Tests for Windows have failed, marking the checks as failed, but I don't think my changes caused that. It looks like the Flutter installation step has issues, can we circumvent the check and merge this to main or do I have to debug the Windows workflow?

No need worry about the unrelated Windows failure, but thanks for thinking about it :) - I've opened a fix in flutter/flutter#150314.

Thanks again for the PR. I'll leave landing the change to @ericwindmill though so he is aware of the update.

@domesticmousedomesticmouse added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 16, 2024
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 16, 2024
@auto-submit

Copy link
Copy Markdown

auto label is removed for flutter/codelabs/2210, due to - The status or check suite Test Flutter beta on windows-latest has failed. Please fix the issues identified (or deflake) before re-applying this label.

@domesticmouse
domesticmouse merged commit 42192df into flutter:mainJun 16, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wrbl606@parlough@domesticmouse