Uh oh!
There was an error while loading. Please reload this page.
Document vector_math Plane API - #12
Conversation
stuartmorgan-g
commented
Jun 3, 2026
I've updated the PR description to reflect that the fact that this PR only address two out of 24 references to that issue. In the future, please don't indicate that a PR will close an issue if it only partially addresses on, as GitHub will auto-close the issue on PR submit with specific keywords that indicate that it's a fix. |
faheemabbas766
commented
Jun 3, 2026
Thanks for the clarification. Understood. I’ll avoid using |
6c05e06 to
94b673bCompare
This comment was marked as off-topic.
This comment was marked as off-topic.
zanderso
commented
Jun 18, 2026
It looks like this PR is failing the dart format presubmit check. |
stuartmorgan-g
commented
Jun 23, 2026
Please see #22 (comment); this needs to use our contribution checklist. |
faheemabbas766
commented
Jun 24, 2026
Thanks for the guidance. I’ve submitted the vector_math documentation changes to the source repository here: https://github.com/google/vector_math.dart/pull/373\n\nI’ll leave this mirror PR as-is for now unless you prefer that I close it. |
zanderso
commented
Jul 20, 2026
Hi @faheemabbas766, sorry about the confusion and crossed wires on our side. The repo at https://github.com/google/vector_math.dart has been archived, and this repo (flutter/core-packages) is the correct target for your PR. |
4e50306 to
0078c4eCompare
Piinks
left a comment
There was a problem hiding this comment.
Oh I forgot, this needs an update to the changelog and pubspec so we can publish as a new release. :)
faheemabbas766
commented
Jul 22, 2026
Addressed, thanks! I bumped I also ran the package validation, formatter check, analyzer, |
Uh oh!
There was an error while loading. Please reload this page.
Summary
PlaneAPI invector_mathandvector_math_64.public_member_api_docsignore for bothPlaneimplementations.CHANGELOG.mdentry for the docs update.Part of flutter/flutter#186827.
Validation
dart analyzedart test test/plane_test.dartdart pub global run flutter_plugin_tools analyze --packages=vector_mathdart pub global run flutter_plugin_tools test --packages=vector_mathdart pub global run flutter_plugin_tools format --packages=vector_math --fail-on-change --no-swift