Add support for displaying coverage in `CodeView` by bkonyi · Pull Request #4700 · flutter/devtools

bkonyi · 2022-11-04T15:22:15Z

This changes adds a toggle to the debugger screen that shows coverage information for the currently selected script.

Coverage enabled:

Coverage disabled:

This changes adds a toggle to the debugger screen that shows coverage information for the currently selected script. Fixesflutter#3862

kenzieschmoll · 2022-11-04T15:31:09Z

 final executionPointIndent = scaleByFontFactor(10.0);
-
+ Color? color;
+ if (coverageHit != null && isExecutable) {


is the isExecutable check enough here? In your screenshot it looked like a line with only an end bracket } came back as executable (it was highlighted in red)

Yeah, I don't think it is. I'll look at what Observatory does.

Observatory is using some private fields to further refine what should be included in coverage information, but this change at least won't include the end bracket anymore.

bkonyi · 2022-11-04T18:20:04Z

Updated screenshot:

bkonyi · 2022-11-04T18:25:40Z

With the proper "small mode" behavior:

kenzieschmoll · 2022-11-04T18:45:22Z

 isSelected: selected,
- hideBorder: true,
+ outlined: false,
+ shape: const RoundedRectangleBorder(


why do we have to manually add this for this button and not for all the other buttons in DevTools? OutlinedButton should have this by default

We only need this since it's part of a "group" of buttons with the refresh button on the right. If we don't do this and we're showing code coverage, the highlighted background won't fill the control completely.
With the custom shape:
Without (notice the rounded edges by the refresh button):

trunghieuvn

LGTM

Add support for displaying coverage in CodeView
8f1b625
This changes adds a toggle to the debugger screen that shows coverage information for the currently selected script. Fixesflutter#3862

bkonyi requested a review from kenzieschmoll November 4, 2022 15:22

bkonyi requested review from a team and elliette as code owners November 4, 2022 15:22