Skip to content

Remove hardcoded useWasm: false for expectedBenchmarkMetrics() - #9518

Merged
elliette merged 2 commits into
masterfrom
web_bench_wasm
Feb 26, 2026
Merged

Remove hardcoded useWasm: false for expectedBenchmarkMetrics()#9518
elliette merged 2 commits into
masterfrom
web_bench_wasm

Conversation

@mdebbar

Copy link
Copy Markdown
Contributor

@mdebbar
mdebbar requested a review from a team as a code ownerNovember 13, 2025 21:54
@elliette

Copy link
Copy Markdown
Member

Sorry for missing this! Looks like the web_benchmarks package still needs to be published?

@mdebbar

Copy link
Copy Markdown
ContributorAuthor

Sorry for missing this! Looks like the web_benchmarks package still needs to be published?

Yes, there was an issue in the flutter/packages repo that prevented the web_benchmarks package from being auto-published. Once that's resolved, I'll rebase this PR and rerun all tests.

@mdebbar

Copy link
Copy Markdown
ContributorAuthor

@elliette do you think this PR requires a release notes entry?

@elliette

Copy link
Copy Markdown
Member

@elliette do you think this PR requires a release notes entry?

Sorry for missing this! No it doesn't, added the label to ignore

@elliette
elliette merged commit 29d9428 into masterFeb 26, 2026
75 of 76 checks passed
@elliette
elliette deleted the web_bench_wasm branch February 26, 2026 21:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mdebbar@elliette