Add dart_skills_lint to devtools and configure it to run in the cli and in tests by reidbaker · Pull Request #9770 · flutter/devtools

reidbaker · 2026-04-14T21:07:39Z

add dart skills lint test and yaml config with instructions for how to use
Add ignore file for valid links that are triggering false positives
resolve readme to correct location

Pre-launch Checklist

General checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read the Flutter Style Guiderecently, and have followed its advice.
I signed the CLA.
I updated/added relevant documentation (doc comments with ///).

Issues checklist

I listed at least one issue that this PR fixes in the description above.
I listed at least one issue which has the contributions-welcome or good-first-issue label.
I did not list at least one issue with the contributions-welcome or good-first-issue label. I understand this means my PR might take longer to be reviewed. But I asked kenzie first.

Tests checklist

I added new tests to check the change I am making...
OR there is a reason for not adding tests, which I explained in the PR description.

AI-tooling checklist

I did not use any AI tooling in creating this PR.
OR I did use AI tooling, and...
- I read the AI contributions guidelines and agree to follow them.
- I reviewed all AI-generated code before opening this PR.
- I understand and am able to discuss the code in this PR.
- I have verifed the accuracy of any AI-generated text included in the PR description.
- I commit to verifying the accuracy of any AI-generated code or text that I upload in response to review comments.

Feature-change checklist

This PR does not change the DevTools UI or behavior and...
- I added the release-notes-not-required label or left a comment requesting the label be added.
OR this PR does change the DevTools UI or behavior and...
- I added an entry to packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md.
- I included before/after screenshots and/or a GIF demo of the new UI to my PR description.
- I ran the DevTools app locally to manually verify my changes.

This does not need release notes because it adds tests and instructions for contributors only.

…o use

reidbaker · 2026-04-16T14:07:23Z

I think this is ready for a second pass.

kenzieschmoll · 2026-04-16T17:21:53Z

 build_runner: ^2.5.4
 flutter_lints: ^5.0.0
+ # Update to published version tracked in https://github.com/flutter/devtools/issues/9771
+ dart_skills_lint:


why do we need the dep here and in tool/pubspec.yaml?

Co-authored-by: Kenzie Davisson <43759233+kenzieschmoll@users.noreply.github.com>

kenzieschmoll · 2026-04-16T21:46:35Z

 dev_dependencies:
 build_runner: ^2.5.4
 flutter_lints: ^5.0.0
+


remove new line

FWIW the reason dart_skills_lint was added here was for ease of cli usage. The comment to share yaml configs is what lead me to move it all to the tools package.

reidbaker · 2026-04-16T21:52:40Z

@@ -0,0 +1,10 @@
+{
+ "skills": {
+ "adding-release-notes": [


This is still required because the example for image does not resolve.

reidbaker · 2026-04-16T21:53:20Z

 dev_dependencies:
 build_runner: ^2.5.4
 flutter_lints: ^5.0.0
+


reidbaker · 2026-04-16T21:54:07Z

 dev_dependencies:
 build_runner: ^2.5.4
 flutter_lints: ^5.0.0
+


FWIW the reason dart_skills_lint was added here was for ease of cli usage. The comment to share yaml configs is what lead me to move it all to the tools package.

…nd in tests (flutter#9770) * add dart skills lint test and yaml config with instructions for how to use * Add ignore file for valid links that are triggering false positives * resolve readme to correct location * Copyright added to new files and issue linked in pubspec * Add link to yaml configuration feature * presubmit feedback * Update tool/test/validate_skills_test.dart Co-authored-by: Kenzie Davisson <43759233+kenzieschmoll@users.noreply.github.com> * Update pubspec.yaml Co-authored-by: Kenzie Davisson <43759233+kenzieschmoll@users.noreply.github.com> * Fix one relative path issues, update version of dart_skills_lint * remove the root dependency on dart_skills_lint * Change todo format * Remove double trailing line --------- Co-authored-by: Kenzie Davisson <43759233+kenzieschmoll@users.noreply.github.com>

@Directory

Add linting to skills repo and fix one skill that used _ instead of kebab case as is defined in the spec https://agentskills.io/specification#name-field. This is similar to the prs to add linting to flutter skills in flutter/flutter#185033 and dev/tool flutter/devtools#9770 AI Assisted pr: antigravity, dragonally Prompt: """ use the skill in /Users/reidbaker/Documents/flutter-skills/tool/dart_skills_lint/skills/dart-skills-lint-validation/SKILL.md to add a test to [dash_site](directory;file:///Users/reidbaker/Documents/dart-lang-site-www/tool/dash_site)/test that validates the skills in @Directory:agents/skills """ --- - [ ] I’ve reviewed the contributor guide and applied the relevant portions to this PR. - [x] This PR doesn't contain automatically generated corrections or text (Grammarly, LLMs, and similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn't use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide](https://github.com/dart-lang/site-www/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Code changes should generally follow the [Dart style guide](https://dart.dev/effective-dart) and use `dart format`. - Updates to [code excerpts](https://github.com/dart-lang/site-shared/blob/main/packages/excerpter) indicated by `<?code-excerpt` need to be updated in their source `.dart` file as well. </details>

reidbaker added 3 commits April 14, 2026 16:30

add dart skills lint test and yaml config with instructions for how t…
2661c38
…o use

Add ignore file for valid links that are triggering false positives
fed7a84

resolve readme to correct location
9c290a1

reidbaker requested review from a team and kenzieschmoll as code owners April 14, 2026 21:07

reidbaker requested review from elliette and removed request for a teamApril 14, 2026 21:07

reidbaker commented Apr 14, 2026
View reviewed changes

Comment thread.agents/skills/dart_skills_lint_ignore.json

kenzieschmoll reviewed Apr 14, 2026
View reviewed changes

Comment threadtool/test/validate_skills_test.dart

kenzieschmoll reviewed Apr 14, 2026
View reviewed changes

Comment thread.agents/skills/README.md

kenzieschmoll reviewed Apr 14, 2026
View reviewed changes

Comment threadtool/test/validate_skills_test.dart

kenzieschmoll reviewed Apr 14, 2026
View reviewed changes

Comment threadpubspec.yaml Outdated

This was referenced Apr 14, 2026
Allow validation to take in a yaml file with the config so that tests and manual commands can automatically stay in sync. flutter/agent-plugins#85
Closed
Depend on published yaml package for dart_skills_lint #9771
Open

reidbaker added 3 commits April 14, 2026 17:52

Copyright added to new files and issue linked in pubspec
eb5547b

Add link to yaml configuration feature
92e8b56

presubmit feedback
cbc4b02

srawlins added the release-notes-not-required label Apr 16, 2026

reidbaker requested a review from kenzieschmoll April 16, 2026 14:06